Closed Bug 1052178 Opened 10 years ago Closed 6 years ago

[Email] Solidify router logic, bail on invalid messages (mainthread -> worker, and back)

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mcav, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

In bug 1048487, we found that we had messed up an event being tossed over the bridge (socket 'end' vs 'close'). This would have been caught with some simple logging and/or bail-on-unknown-message logic in the routing handling methods.

:asuth's notes on what we should do in this bug follow:

- have net-main.js and all of its friends have a 'default' case that throws if they see a message they don't understand.
- ensure our router logic has a try/catch mechanism in place with a hook or something so that if any of our router logic throws that we end up with the GELAM test in question failing.  This may currently fall into an 'onerror' black hole, unsure.
See Also: → 1048487
Attached file null
Attachment #8471185 - Attachment is obsolete: true
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: