1052239 - MSE main thread assertion when seeking

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

When seeking in an MSE video an assertion occurs about calling MediaSource::ActiveSourceBuffers on a non-main thread. This assertion was added in a recent landing.

Steps to reproduce:

1) Visit http://cd.pn/mse/ytdemo/dash-player.html?url=http://cd.pn/mse/ytdemo/feelings2.mpd
2) When video plays, seek somewhere

Expected result

3) Video seeks

Actual result

4) Firefox crashes with assertion

Comment 1

[cajbir (:cajbir)]

Attachment: 1052239.patch

Iterate through decoders instead of source buffers.

Comment 2

[Matthew Gregan [:kinetik]]

Comment on attachment 8471304 [details] [diff] [review]
1052239.patch

Review of attachment 8471304 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments.

Remove SourceBuffer::ContainsTime and SourceBufferList::AllContainsTime since they're no longer used.

::: content/media/mediasource/SubBufferDecoder.cpp
@@ +133,5 @@
> +  nsresult rv = GetBuffered(ranges);
> +  if (NS_FAILED(rv) || ranges->Length() == 0) {
> +    return false;
> +  }
> +  for (uint32_t i = 0; i < ranges->Length(); ++i) {

Use TimeRanges::Find please.

Comment 3

[cajbir (:cajbir)]

Attachment: Fix

Address review comments. Carry r+ forward.

Comment 4

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c8eb8d36d19

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c8eb8d36d19