Closed Bug 1052262 Opened 10 years ago Closed 7 years ago

--enable-elf-hack conflicts with --enable-profiling:

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file)

After pushing the necessary patch to make all the c-* trees build again,
the compile process chokes early with the following:

checking for jar... :
checking for jarsigner... :
checking for keytool... :
checking for linux/joystick.h... yes
checking for gthread-2.0... yes
checking MOZ_GTHREAD_CFLAGS... -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include  
checking MOZ_GTHREAD_LIBS... -pthread -lgthread-2.0 -lrt -lglib-2.0  
configure: warning: Removing gio from MOZ_EXTENSIONS due to --disable-gio.
checking for gnutar... no
checking for gtar... gtar
checking for wget... wget
checking for valid optimization flags... yes
checking for /usr/bin/ccache... /usr/bin/ccache
configure: error: --enable-elf-hack is not compatible with --enable-profiling

And with bug 794772 fixed, I think we can also remove the --disable-gio
and --enable-gnomevfs.  (will file a bug on t his)
(In reply to Edmund Wong (:ewong) from comment #0)

> And with bug 794772 fixed, I think we can also remove the --disable-gio
> and --enable-gnomevfs.  (will file a bug on t his)

This is bug 1052263.
Depends on: 788974
when the dependent bug is fixed, this patch can then be backed out.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8472023 - Flags: review?(bugspam.Callek)
For now I think this change is fine. Bug 788974 looks like it might still take a while until it is resolved.
I'm going to do a post-push review:  If it's not right, I can always back it out.
Comment on attachment 8472023 [details] [diff] [review]
disable patch (v1)

Review of attachment 8472023 [details] [diff] [review]:
-----------------------------------------------------------------

wfm, please cross-land on any necessary trains. with a=me
Attachment #8472023 - Flags: review?(bugspam.Callek) → review+
From Comment 6, I'm going to land on c-a
Pushed to comm-aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/7bb964f4c3f9

c-b doesn't need it (and will probably get this patch with the next uplift.
I'm holding off on c-r (it's currently busted because of bug 1053081).
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.