Closed
Bug 1052331
Opened 10 years ago
Closed 10 years ago
Remove the "LooP" title from the conversation window when it is initially opened
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox34 verified)
VERIFIED
FIXED
mozilla34
| Tracking | Status | |
|---|---|---|
| firefox34 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
Sometimes when the conversation window is opened, we see "LooP" in the title, before the page has loaded. We should either leave it blank or use the incoming call title.
|
Assignee | |
Comment 1•10 years ago
|
||
This replaces the title with "Incoming call..." which is what we display once about:loopconversation has loaded. I believe there's a little bit of flicker, but I think the only way to avoid that would be to have a null title, which is possibly reasonable as well.
Attachment #8471464 -
Flags: review?(mdeboer)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8471464 [details] [diff] [review] Remove the 'LooP' title from the conversation window when it is initially opened. Review of attachment 8471464 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thanks!
Attachment #8471464 -
Flags: review?(mdeboer) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9a8e73e7757d
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
Priority: -- → P1
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9a8e73e7757d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed in today's Nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Contact: anthony.s.hughes
status-firefox34:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•