1052425 - [Single Variant] The Build process isn't calculating correctly the single variant apps position.

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Carmen Jimenez Cabezas]

The Build process isn't calculating correctly the single variant apps position.

STR:

1.- Clone the directory:
https://github.com/telefonicaid/firefoxos-gaia-testsbuild

Be sure that singleVariant apps in variant.json for the SIM you're going to use to test are:

{
  "id": "Calculator",
  "screen": 1,
  "location": 2
},
{
  "id": "Wikipedia",
  "screen": 2,
  "location": 0
},
{
  "id": "Sudoku",
  "screen": 0,
  "location": 0
},

(The actual apps don't matter, only the screen & location are important for this test)

2.- Execute:

GAIA_DISTRIBUTION_DIR=/home/cjc/dev/firefoxOS-testBuild PRODUCTION=1 make profile

Expected:

  The singlevariantconf.json file inside the verticalhome apps zip on the profile directory 
should be:

...
"214-007":[
{
  "location":0,
  "manifestURL": "http://owd.tid.es/store/packages/9a379e01c540e90e6ecf5fd126943e14.webapp"
},{
  "location":8,
  "manifestURL":"https://marketplace.firefox.com/app/9f96ce77-5b2d-42ca-a0d9-10a933dd84c4/manifest.webapp"
},{
  "location":11,
  "manifestURL":"https://bits.wikimedia.org/WikipediaMobileFirefoxOS/manifest.webapp"
},{
  "manifestURL":"http://owd.tid.es/operRes/latam/operatorResourcesLatam.webapp"
}]
...

Actual:
  The singlevariantconf.json file inside the verticalhome apps zip has:

...
"214-007":[
{
  "location":0,
  "manifestURL": "http://owd.tid.es/store/packages/9a379e01c540e90e6ecf5fd126943e14.webapp"
},{
  "location":9,
  "manifestURL":"https://marketplace.firefox.com/app/9f96ce77-5b2d-42ca-a0d9-10a933dd84c4/manifest.webapp"
},{
  "location":12,
  "manifestURL":"https://bits.wikimedia.org/WikipediaMobileFirefoxOS/manifest.webapp"
},{
  "manifestURL":"http://owd.tid.es/operRes/latam/operatorResourcesLatam.webapp"
}]

Comment 1

[Albert [:albert]]

After some testing I think that expected behavior detailed in comment 1 is wrong.

The grid applications used to generate the singlevariantconf.json is:

[{"name":"Phone"},{"name":"Messages"},{"name":"Browser"},{"name":"Camera"},{"name":"FM Radio"}]

If we add the single variant application at 0,0 (sudoku), we have:

[{"name":"Sudoku"},{"name":"Phone"},{"name":"Messages"},{"name":"Browser"},{"name":"Camera"},{"name":"FM Radio"}]

Then, adding the 'calculator' at 1,2:

[{"name":"Sudoku"},{"name":"Phone"},{"name":"Messages"},{"name":"Browser"},{"name":"Camera"},{"name":"FM Radio"}]['separator'][{"name":"Game Pack"},{"name": "Gallery"},{"name":"Calculator"}]

So, location for calculator in 'singlevariantconf.json' should be 9, as it is in verticalhome zip

Comment 2

[Carmen Jimenez Cabezas]

Yes, you're right. As we talked before offline, the bug is invalid, the positions are calculated correctly. Sorry for the noise