1052473 - Fix failure in test_setup_and_send_imap_email.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

In commit https://github.com/mozilla-b2g/gaia/commit/0188b33d33ae111e918e13adf0f36a681fae8e41 a email signature was introduced when creating an email: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.functional.smoke/64/HTML_Report/
The signature appears in the body of the email, which causes test_setup_and_send_imap_email.py to fail while asserting: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/email/test_setup_and_send_imap_email.py#L66.
We should update our test to use only the body content, and not the signature.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22787

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8471609 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22787

Could we do an assertIn instead? I suppose that would make the assertion failure less useful. Maybe a splitlines? See https://docs.python.org/2/library/stdtypes.html#str.splitlines

Comment 3

[Viorela Ioia [:viorela]]

Comment on attachment 8471609 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22787

Updated to use assertIn. Can I get another review? Thanks!

Comment 4

[Viorela Ioia [:viorela]]

(In reply to Viorela Ioia [:viorela] from comment #3)
> Comment on attachment 8471609 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22787
> 
> Updated to use assertIn. Can I get another review? Thanks!

Actually, I decided to use splitlines instead.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8471609 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22787

Good call. Thanks Viorela!

Comment 6

[Robert Chira [:RobertC]]

Merged on master:
https://github.com/mozilla-b2g/gaia/commit/2a73503ae58d97d27e1c161950858c0fb5363cb3