Add-ons Flashblock and FlashStopper conflict with Bug 1050049

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
2 months ago

People

(Reporter: streetwolf, Unassigned)

Tracking

({regression})

Trunk
x86_64
Windows 8.1

Firefox Tracking Flags

(firefox34+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140812063855

Steps to reproduce:

Make sure https://bugzilla.mozilla.org/show_bug.cgi?id=1050049 is installed.

Install Falshstopper or Flashblock.




Actual results:

Videos will no longer play.


Expected results:

Videos should play the way these add-ons intended them to.
(Reporter)

Comment 1

5 years ago
Regression:

Good: 20140811200055  https://hg.mozilla.org/integration/mozilla-inbound/rev/d78a39f01102
Bad:  20140811200755  https://hg.mozilla.org/integration/mozilla-inbound/rev/9648b3e555db
Component: Untriaged → Untriaged
Keywords: regression
Product: Firefox → Core
Summary: Add-ons Flashblock and FlashStopper conflict with https://bugzilla.mozilla.org/show_bug.cgi?id=1050049 → Add-ons Flashblock and FlashStopper conflict with Bug 1050049
(Reporter)

Updated

5 years ago
Component: Untriaged → XBL
(Reporter)

Updated

5 years ago
Depends on: 1050049
(Reporter)

Updated

5 years ago
Blocks: 1050049
No longer depends on: 1050049
Confirmed, setting to NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whitelisting site in Flashblock still won't allow vids to play, addon must be disabled.
You need to add bindToUntrustedContent=true in any binding that gets applied to content, and all of the bindings it inherits. It should be a simple fix - let me know if it's problematic for some reason.
(Reporter)

Comment 5

5 years ago
bindToUntrustedContent=true was added to flashstopper and it now works.  I modified FlashBlock myself. adding the new parameter, and that works too.  The developer of FB hasn't made the update yet.

So how does a developer know he/she has to add this new parameter when his add-on doesn't work right?
(In reply to Gary [:streetwolf] from comment #5)
> bindToUntrustedContent=true was added to flashstopper and it now works.  I
> modified FlashBlock myself. adding the new parameter, and that works too. 
> The developer of FB hasn't made the update yet.
> 
> So how does a developer know he/she has to add this new parameter when his
> add-on doesn't work right?

If they run a debug build, they'll see console spew explaining that they should do this. I've also flagged bug 1050049 for a relnote and mention on the addon compat blog.

Comment 7

5 years ago
I've installed Gary's fixed FlashBlock, and it fixes some sites. 

On my own site, however, videos still don't work, e.g. http://edu-net.net/media/flashprob/

They work with FlashBlock disabled, and they also work on 24.7.9esrpre

These are the only testing modalities I have available.
[Tracking Requested - why for this release]:

(In reply to Boris Zbarsky [:bz] from comment #9)
> [Tracking Requested - why for this release]:

I'll track this but would like to have someone assigned.

Updated

5 years ago
Duplicate of this bug: 1081757
Barring further information from the Flashblock and FlashStopper devs, I'm considering this an addon-bug. This isn't actionable for me, though it's worth making sure that those addons get properly updated in a timely manner, so that actual Gecko bugs (if they exist) are uncovered in time to fix them.

Comment 13

5 years ago
It's pretty obvious that the FlashBlock author isn't active any more and isn't going to make any changes (it seems the last time the plugin was updated is in April 2013, so we can assume it's dead and has already begun bitrotting).  This is problematic because it's an extremely popular plugin, so if Firefox 34 is released and breaks it, many users will be very unhappy.  Wouldn't it be possible for someone to do a "non maintainer update" (as Debian calls them) to the plugin, if it's as trivial as adding bindToUntrustedContent="true" to <binding> elements in two places?  (Although according to what JoeG says in comment 7 above, there are still remaining issues.)

Comment 14

5 years ago
I'm afraid it's not a simple fix, bindToUntrustedContent="true" works only part, because video is loaded in background anyway and sometimes audio plays but not video. I'm afraid it has to be marked as incompatible and be dumped. I'd love to have something like this natively in firefox tho... I don't want to compare to other browsers, but Opera since they switched to chromium, has click to play feature that works exactly like flashblock did. And if I'm not wrong Chromium on Linux has that option as well.

Comment 15

5 years ago
I'm a bit confused about the situation: does this mean that there's no way in FF34 to implement an extension that does what FlashBlock used to do?  Or simply that it needs to be done differently?  (How?)  Because in the first case, it seems like a catastrophic situation (especially given the number of security vulnerabilities in Flash).  In the second case, is there another addon that can be recommended instead of FlashBlock that would reliably block Flash except for a number of whitelisted sites?

Comment 16

5 years ago
About flash video( http://edu-net.net/media/flashprob/ ) in comment 7 ,
Modified version of Flashblock works for me on Nightly36.0a1, Aurora35.0a2 as well as Beta34.0b1.


https://hg.mozilla.org/mozilla-central/rev/62f0b771583c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 ID:20141015030202

https://hg.mozilla.org/releases/mozilla-aurora/rev/189ac924dfa6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 ID:20141015004006

https://hg.mozilla.org/releases/mozilla-beta/rev/00cf6dd17a10
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20141014060655

Comment 17

5 years ago
ohhh... I will test them right away! Where did you get those for 36?

Comment 18

5 years ago
Still the same in FF36. When I reload youtube page, video loads in background. When I set dom.ipc.processCount > 1 it's even worse, commercial loads with sound only, with "skip ad" button, if I click on play button before commercial ends it of course brings me to the commercial's webpage, when I click on "skip ad" I can then click play youtube video.

Comment 19

5 years ago
(In reply to fatrat from comment #18)
> Still the same in FF36. When I reload youtube page, video loads in
> background. When I set dom.ipc.processCount > 1 it's even worse, commercial
> loads with sound only, with "skip ad" button, if I click on play button
> before commercial ends it of course brings me to the commercial's webpage,
> when I click on "skip ad" I can then click play youtube video.

On Nightly36, Youtube is HTML5 video, not Flash Player .

Comment 20

5 years ago
I have tested it a bit more with dom.ipc.processCount = 1, I have opened few more youtube videos and it sometimes plays audio regardless of the play icon. So I spoke to fast with processCount...

Comment 21

5 years ago
flashblock blocks HTML5 as well.

Comment 22

5 years ago
sry, blocked*
Jorge - As per comment 12, this bug requires updates to a popular add-on whose author looks to be inactive. Do you have any additional options?

bsmedberg - As a possible replacement for Flashblock, is it possible to create an add-on that sets click-to-play for all Flash content?
Flags: needinfo?(jorge)
Flags: needinfo?(benjamin)
Yes, but it depends on what kind of click-to-play you want. There is the Firefox-default per-site kind, and there is the per-element kind https://addons.mozilla.org/en-US/firefox/addon/click-to-play-per-element/

Knowing almost nothing about flashblock, I don't know what the user expectations would be.
Flags: needinfo?(benjamin)
Philip, do you have any plans of updating your add-on, given it will be broken in 34 and above?

Lawrence: flagging it as incompatible is the way to go here. There are some alternatives we can suggest to users: https://addons.mozilla.org/firefox/search/?q=flash+block
Flags: needinfo?(jorge)
Philip, do you have any plans of updating your add-on, given it will be broken in 34 and above?
Flags: needinfo?(philip.chee)
Component: XBL → Add-ons
Product: Core → Tech Evangelism
Version: 34 Branch → Trunk

Comment 27

5 years ago
(In reply to Jorge Villalobos [:jorgev] from comment #26)
> Philip, do you have any plans of updating your add-on, given it will be
> broken in 34 and above?
Yup I plan to update it. Sorry for the extreme procrastination.

Comment 28

5 years ago
with seamonkey 2.31 beta 1 problem... html5, no film frame (only speak/music), with flash (youtube) no work. only black window.

Comment 29

5 years ago
(In reply to Mario from comment #28)
> with seamonkey 2.31 beta 1 problem... html5, no film frame (only
> speak/music), with flash (youtube) no work. only black window.

Could you possibly post the Graphics portion of about:config?

Comment 30

5 years ago
>>> Could you possibly post the Graphics portion of about:config?

If you tell me where to find these infos... I normally don't try to change something in there.

Comment 31

5 years ago
(In reply to Mario from comment #30)
> >>> Could you possibly post the Graphics portion of about:config?
> 
> If you tell me where to find these infos... I normally don't try to change
> something in there.

Sure. In the URL bar, type about:support, press Enter. You should see the option to Copy text to Clipboard. I'm curious about the info under Graphics section.

Comment 32

5 years ago
The best fix at this point is to not update to FF34 until Philip's fixed it. I could not use Firefox without this add-on. Youtube is a complete PITA.
I added current versions a Flashblock to the compatibility override list and are waiting for an update. FlashStopper claims to work with 34 for its latest version.
(In reply to Jorge Villalobos [:jorgev] from comment #33)
> I added current versions a Flashblock to the compatibility override list and
> are waiting for an update. FlashStopper claims to work with 34 for its
> latest version.

While waiting for a fix in 34, there is no reason to block this in Nightly builds, its working just fine with a 3rd party update.

How can this block be over-ridden?
(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #34)
> While waiting for a fix in 34, there is no reason to block this in Nightly
> builds, its working just fine with a 3rd party update.

What do you mean by this? If you're changing its code then all you need it to increase the version number and it should work.

> How can this block be over-ridden?

I think you would need to disable compatibility checks for all add-ons. I don't remember the pref change(s) required for this.

Comment 36

4 years ago
With flashblock, the first boot in release 34, it didn't immediately disable the addon, so I had a time where it was enabled and bork3n.  Went disabled after restarting the browser.  So for less techy users, that might be bad.

Comment 37

4 years ago
So 34 is now the current stable release. Flashblock is kaput. What are we all doing?

Comment 38

4 years ago
The following addons and setting seem to replicate most of the features of Flashblock:

In Addons > Plugins: 
* Set Flash to Ask to Activate.
* Set Silverlight to Ask to Activate.

Install:
* https://addons.mozilla.org/en-US/firefox/addon/click-to-play-per-element/
* https://addons.mozilla.org/en-US/firefox/addon/hide-plugin-notifications/
* https://addons.mozilla.org/en-US/firefox/addon/click-to-play-manager/

Optional about:config setting
* Set "plugin.sessionPermissionNow.intervalInMinutes" to "0" (zero)

How to use:
* To enable Flash for a single element, just click on it.
* To enable Flash for the entire page, click the plugin button in the address bar 
  and choose the appropriate option.
  * If you want one time activation per page, use the "Allow Now" option and use 
    the optional about:config setting.

The only thing left out is the ability to block HTML5 video. The closest I can find with existing addons is to use the following with the HTML5 module option:

* https://addons.mozilla.org/en-US/firefox/addon/video-without-flash/

Unfortunately, with that, you'll have no whitelist for HTML5.

Comment 39

4 years ago
Thanks Terrell, but this is a rather clunky and unsatisfactory implementation. I worry about the direction that Firefox is heading. It's quite a dog straight out of the box.

Comment 40

4 years ago
User streetwolf on the MozillaZine forums posted a fixed version of Flashblock[1] for Firefox 34. I've mirrored it in github[2]. Also below is the diff when you extract and compare the two versions.

[1]: http://forums.mozillazine.org/viewtopic.php?p=13905701#p13905701
[2]: https://github.com/diafygi/flashblock-firefox34/raw/master/flashblock-1.5.17-fx.xpi

================================
diff --git a/chrome/content/flashblock/flashblock.xml b/chrome/content/flashblock/flashblock.xml
index 7420604..1bc0ed9 100644
+++ a/chrome/content/flashblock/flashblock.xml
--- b/chrome/content/flashblock/flashblock.xml
@@ -5,7 +5,7 @@
    xmlns:html="http://www.w3.org/1999/xhtml"
 >
 
+<binding id="flash">^M
-<binding id="flash" bindToUntrustedContent="true">
   <implementation>
     <constructor>
         <![CDATA[
diff --git a/chrome/content/flashblock/videoblock.xml b/chrome/content/flashblock/videoblock.xml
index 0244ffb..902c4ad 100644
+++ a/chrome/content/flashblock/videoblock.xml
--- b/chrome/content/flashblock/videoblock.xml
@@ -5,7 +5,7 @@
    xmlns:html="http://www.w3.org/1999/xhtml"
 >
 
+<binding id="html5video">^M
-<binding id="html5video" bindToUntrustedContent="true">
   <implementation>
     <constructor>
         <![CDATA[
diff --git a/install.rdf b/install.rdf
index 80b76c6..4b9d71f 100644
+++ a/install.rdf
--- b/install.rdf
@@ -7,7 +7,7 @@
         <em:type>2</em:type>
         <em:unpack>true</em:unpack>
         <em:name>Flashblock</em:name>
+        <em:version>1.5.17</em:version>^M
-        <em:version>1.5.18</em:version>
         <em:description>Replaces Flash objects with a button you can click to view them.</em:description>
         <em:creator>The Flashblock Team</em:creator>
         <em:contributor>Ted Drake</em:contributor>
@@ -27,7 +27,7 @@
             <Description>
                 <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
                 <em:minVersion>3.5</em:minVersion>
+                <em:maxVersion>23.0</em:maxVersion>^M
-                <em:maxVersion>99</em:maxVersion>
             </Description>
         </em:targetApplication>
================================

Comment 41

4 years ago
Thanks Daniel, so far, so good!
FYI: Flashblock has been updated as of 2014/12/09 on addons.mozilla.org with the help of streetwolf's patch.
Looks like we're done here. Thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(philip.chee)
Resolution: --- → FIXED
Duplicate of this bug: 1109385

Comment 45

4 years ago
Mostly to philip.chee@, maybe also to rrayborn@, depending on who got the last release out: Do note the change included in flashblock-1.5.18 is not quite complete.  It works for almost everything, but 1.5.18 doesn't set bindToUntrustedContent="true" on the #brokenobject element in flashblock.xml, so sites that are still using the <object><param movie="..."></param><embed type=... src=...></embed></object> setup don't get the button.

I've added that attribute locally and rebuilt flashblock.jar, and it seems to work for me.  (Testcase: http://www.shamusyoung.com/twentysidedtale/?p=25395)

It's also not clear if the other <binding> tags in the xml file need the attribute set (that is, #director, #authorware, #silverlight, #sifr-replaced, and #sifr-alternate).  The first three might inherit it from #flash, since they have extends="#flash" (though comment #4 makes it sound like they need it individually).  But #brokenobject doesn't extend that way, and didn't bind, so I bet at least the two sifr- variants need the attribute too.

Maybe a 1.5.18.1 is in order?

Comment 46

4 years ago
(In reply to Bryan Kadzban from comment #45)
> I've added that attribute locally and rebuilt flashblock.jar, and it seems
> to work for me.  (Testcase:
Oh Thanks Bryan! Very sorry for forgetting to fix all the other bindings. Will put out an update ASAP!.

Very much obliged!

Comment 47

4 years ago
(In reply to Philip Chee from comment #46)
> (In reply to Bryan Kadzban from comment #45)
> > I've added that attribute locally and rebuilt flashblock.jar, and it seems
> > to work for me.  (Testcase:
> Oh Thanks Bryan! Very sorry for forgetting to fix all the other bindings.
> Will put out an update ASAP!.
> 
> Very much obliged!

Any news on the updated (1.5.18.1) Flashblock?

Comment 48

4 years ago
I want to confirm. Several versions of Seamonkey (and FF) on a Windows and multiple Linux installs. Flashblock is the first addon I install on every fresh SM/FF build. It keeps 90% of web's nastiness off me. :)
I could not name the problem in the past month(s), but now videos stopped playing at all. flash, HTML5 nothing would work. Sometimes black screen with audio. Using a popular search engine I found this bug report. After disabling (not just dis-enabling) flashblock things went back to normal.

Flash is a pest, security issue no. 1 and besides JavaScript the reason why "the web" is slow and a cause for crashes. 
The problem is: We still need it because some websites even use it for navigation, some others provide content via flash.
But we need any solution to block it from getting automatically downloaded and starting.

Comment 49

4 years ago
(In reply to Philip Chee from comment #46)
> (In reply to Bryan Kadzban from comment #45)
> > I've added that attribute locally and rebuilt flashblock.jar, and it seems
> > to work for me.  (Testcase:
> Oh Thanks Bryan! Very sorry for forgetting to fix all the other bindings.
> Will put out an update ASAP!.
> 
> Very much obliged!

Any chance that v1.5.18.1 will be out soon?

Comment 50

4 years ago
Appears to be an issue occuring with the update to Firefox 39 beta where some pages will 'eternally load' when flash block is enabled, but work fine with other similar extensions such as flash control.

For example http://www.nwanime.com/teekyuu-4-episode-9/video/9fe560653079c5529f8a/

most sites encountered were not a problem.
(Assignee)

Updated

2 months ago
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.