Closed Bug 1052489 Opened 10 years ago Closed 10 years ago

Add the jobtype description to tooltips for jobs

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: Sylvestre, Mentored)

References

Details

Attachments

(1 file, 2 obsolete files)

The jobtype table has a description field, but we currently aren't using it.

To allow for bug 1051508, we should make help and also possibly tooltips (depends on length I guess?) show this description after the test name.
Bug 1053203 is now covering the treeherder help page, so I'm morphing this bug to just be about the tooltips.
No longer blocks: 1051508
Depends on: 1051508
Summary: Help & tooltips should also display the jobtype description → Add the jobtype description to tooltips for jobs
Mentor: mdoglio
I could update the code to silent when the default value is used
if (job_type_description !== "fill me") 

Just let me know what you prefer
Attachment #8475959 - Flags: review?(mdoglio)
Assignee: nobody → sledru
Status: NEW → ASSIGNED
Attachment #8475959 - Attachment is obsolete: true
Attachment #8475959 - Flags: review?(mdoglio)
Attachment #8477473 - Flags: review?(mdoglio)
Comment on attachment 8477473 [details] [diff] [review]
0001-Bug-1052489-Update-the-tooltip-to-show-the-descripti.patch

Review of attachment 8477473 [details] [diff] [review]:
-----------------------------------------------------------------

::: webapp/app/js/directives/clonejobs.js
@@ +53,5 @@
>  
>          var jobStatus = thResultStatus(job);
> +        var result;
> +        if (job.job_type_description !== "fill me") {
> +            result = job.job_type_name + " (" + job.job_type_description + ") " + " - " + jobStatus;

we may want to place the description at the end of the string so that you don't have to read the entire description to see the job status. maybe :edmorley has a better opinion on this
Attachment #8477473 - Flags: feedback?(emorley)
Comment on attachment 8477473 [details] [diff] [review]
0001-Bug-1052489-Update-the-tooltip-to-show-the-descripti.patch

Review of attachment 8477473 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah agree with Mauro, let's put the description at the end.
Also I think maybe we should put a limit on the number of characters shown (I don't know what the field limit is in the DB) - perhaps a couple of hundred chars? Maybe just experiment with some dummy text and see what look acceptable :-)

Other than that looks good - thank you for doing this!
Attachment #8477473 - Flags: feedback?(emorley) → feedback+
Updated patch
Attachment #8477473 - Attachment is obsolete: true
Attachment #8477473 - Flags: review?(mdoglio)
Attachment #8478137 - Flags: review?(mdoglio)
Attachment #8478137 - Flags: review?(mdoglio) → review+
Hi Sylvestre! We just pushed latest master to dev which should include your commit, so you should be able to test the behavior and mark this bug resolved there. Stage and prod will likely also get pushed later today.
dev: http://treeherder-dev.allizom.org
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ce36c5bc88884a771081e4e6fe8a658df8e07d52
Bug 1052489 - Update the tooltip to show the description Default value ("fill me") is not displayed r=mdoglio
See Also: → 1229782
See Also: 1229782
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: