1052553 - UI Cleanup on app status page for delist/delete functionality

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Rob Hudson [:robhudson]]

Attachment: Screenshot 2014-08-12 10.10.52.png

In bug 1006816 some mocks were created that gave special UI treatment to the delist/delete sections. These were nice changes, let's implement them.

Comment 1

[Andrew Williamson [:eviljeff]]

can you link to the mocks or detail the changes?

Comment 2

[Rob Hudson [:robhudson]]

The attached screenshot in comment 0 is all that this bug is about.

If you'd like to see the full mocks they are here:
http://people.mozilla.org/~ehunt/bug_1006816_unlisted_apps/unlisted_apps_ui.pdf

Comment 3

[sandeep504kmr]

i would like to fix this bug

Comment 4

[Ram Dayal Vaishnav [:ram]]

Sure Sandeep. Assigning you to this bug.

For any help you can refer to the documentation at http://marketplace.readthedocs.org/, or ask in #marketplace irc channel.

Comment 5

[Ram Dayal Vaishnav [:ram]]

Hi Sandeep, 

if you find any issues in understanding or fixing this, feel free to ask here.

Comment 6

[Andreas Wagner [:TheOne] [use NI]]

There hasn't been any activity on this bug for a while. Are you still working on it?

Comment 7

[Amy Tsay [:amyt]]

Hi Andres, another goodfirstbug you can take if you're interested.

Comment 8

[Andres O Serrano [:omarS]]

Could you point me to how to land in the app status page? It looks like I may have to go through the upload app process first, right?

Comment 9

[Rob Hudson [:robhudson]]

(In reply to Andres O Serrano [:omarS] from comment #8)
> Could you point me to how to land in the app status page? It looks like I
> may have to go through the upload app process first, right?

Yes, create an app and go to its "Status" page.

Comment 10

[Andres O Serrano [:omarS]]

Attachment: ui-changes.png

Could you let me know if I should make further UI adjustments based on my screenshot? 
Also, is there content/text to be applied to the button and paragraph for when the app is hidden? (Hide This App could be Show This App? etc.)

Comment 11

[krupa raj[:krupa]]

Yes, We should alter the copy when the app is in the disabled status.

Please change the copy to -

This app is hidden from all users and is not listed anywhere. You can make it publicly available again at any time.

Thanks!

Comment 12

[Andres O Serrano [:omarS]]

Created pull request, https://github.com/mozilla/zamboni/pull/3339 .

Comment 13

[Rob Hudson [:robhudson]]

Removing NI flag since question has been answered.

Comment 14

[Andres O Serrano [:omarS]]

Wanted to give quick update on this task. I jumped ahead of myself in previous comment about pull request link and actually still need to fix some issues with my branch. Will work on this.

Comment 15

[David Durst [:ddurst]]

OK, we'll wait to re-assign a mentor when you come back, since Rob has changed teams.

Comment 16

[David Durst [:ddurst]]

(In reply to Andres O Serrano [:omarS] from comment #14)
> Wanted to give quick update on this task. I jumped ahead of myself in
> previous comment about pull request link and actually still need to fix some
> issues with my branch. Will work on this.

Any progress on this?

Comment 17

[meghasharma4910]

Any progress on this? Can I take it up?

Comment 18

[Andrew Williamson [:eviljeff]]

Marketplace is not longer under development and will be decommissioned entirely in the coming months, so there no point in working on this.
AMO (addons.mozilla.org) and Marketplace share a common origin, if you're looking to contribute to a django/python/js project https://wiki.mozilla.org/Add-ons/Contribute/AMO/Code

Comment 19

[BMO Automation]

Firefox Marketplace has been shut down since March. Closing remaining bugs.