Closed
Bug 1052634
Opened 11 years ago
Closed 11 years ago
Protecting task-specifc routing keys under a scope
Categories
(Taskcluster :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jonasfj, Unassigned)
Details
We've discussed protecting task-routing keys under scopes and making it possible to have
more routing keys using CC on rabbitmq.
I've written a proposal here:
https://etherpad.mozilla.org/jonasfj-taskcluster-routing-key-rethink
This shouldn't be too hard to implement, mostly it just concerns the queue.
The proposal will include the usual routing keys in all routes, which may or may not be sane. I suspect it is as we should otherwise use a different exchange for task-specific routing keys (this is also an option).
Following my proposal we can add additional entries to the set of usual keys.
And for this reason we shouldn't give the full available key space to the task-specific routing key. There is about 88 characters left after the usual keys.
I suggest we only hand out 45, or maybe only 22 or so for task-specific routing key.
We can always assign more.
Reporter | ||
Comment 1•11 years ago
|
||
@jlal,
Thoughts?
Again this is somewhat easy fix... But it break taskcluster-client and exchanges in taskcluster-base.
So it's something we need to do NOW if we want it.
Let me know if you agree and I'll go ahead, when nothing else is pressing me.
Feel free to reprioritize if you want this faster :)
Flags: needinfo?(jlal)
Comment 2•11 years ago
|
||
We should do it this week sometime it is something we desperately need as we connect some dots... I wanted to a run a quick experiment based on your proposal but I think this looks good as is. Will post back a little later today.
Flags: needinfo?(jlal)
Reporter | ||
Comment 3•11 years ago
|
||
Resolved this last week... enjoy...
By the way, I think this was our last breaking change.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Comment 4•10 years ago
|
||
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•