Closed
Bug 1052690
Opened 10 years ago
Closed 10 years ago
Feed elements should not rely on absolute positioning for layout
Categories
(Marketplace Graveyard :: Curation Tools, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chuck, Assigned: spasovski)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file)
|
105.04 KB,
image/png
|
Details |
Screen Shot 2014-08-12 at 3.52.21 PM.png
Feedback from sdevaney: Collection headlines should wrap to two lines as needed. Example: "Welcome to the New Firefox Marketplace" looks like: "Welcome to the New Firefox M..." In languages with typically lengthy words (e.g. German, Greek, Russian) we will encounter a lot of problems if we can't truncate headlines.
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → charmston
|
|
Reporter | |
Comment 2•10 years ago
|
||
Halfway there: https://github.com/mozilla/transonic/compare/72ea92931c33...b0e749ac4a6a
|
|
Reporter | |
Comment 3•10 years ago
|
||
And the other half. https://github.com/mozilla/fireplace/compare/7df43273f8e7...285f6cbedbf3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 4•10 years ago
|
||
On second thought, [qa+] because it may well break existing feed items.
Whiteboard: [qa+]
|
||
Comment 5•10 years ago
|
||
The usecase in comment 0 is not fixed @ https://marketplace-feed-dev.allizom.org/feed/collection/welcome?src=feed
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 6•10 years ago
|
||
Not looking too good.
|
|
Reporter | |
Comment 7•10 years ago
|
||
@Kevin: that's because everything is absolutely positioned in that view. Davor is working on that.
|
|
Reporter | |
Comment 8•10 years ago
|
||
@Krupa: comment 5 is addressed now. Assigning to Davor, who is working on the issues in comment 6.
Assignee: charmston → dspasovski
|
||
Updated•10 years ago
|
Priority: -- → P1
|
|
Reporter | |
Updated•10 years ago
|
Summary: Remove clamping from all titles and descriptions → Feed elements should not rely on absolute positioning for layout
|
Assignee | |
Comment 9•10 years ago
|
||
https://github.com/mozilla/fireplace/commit/3844441
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•10 years ago
|
||
I think this means nodes within the feed elements.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 11•10 years ago
|
||
Sorry accidentally reopened
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•