Get fireplace/feed localization into Verbatim

RESOLVED FIXED

Status

Marketplace
Curation Tools
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: chuck, Assigned: ngoke)

Tracking

Avenir
Points:
---

Details

(Whiteboard: [qa-])

(Reporter)

Description

3 years ago
Feedback from sdevaney:

I need to be able to enter localized strings for EdBrands ASAP (they currently reflect their Tool keys on user-facing site). EdBrands will be our most frequently utilized editorial content modules specifically because they are pre-localized and thus efficient to publish day to day. 

Examples on dev include EdBrands simply labelled "Music" and "Photo & Video" whereas the ideal nomenclature for these EdBrands in English would be "For Music Lovers" and "Featured Camera Apps" respectively.

---

This probably needs to be done as a separate project until the feed branch is merged, lest we accidentally remove strings from currently-deployed code.
(Assignee)

Comment 1

3 years ago
How about we just merge feed.js into master? It won't affect anything, but verbatim will still catch it.
(Reporter)

Comment 2

3 years ago
That would still miss other strings (e.g. from templates), which also need to be translated before merge.
(Assignee)

Comment 3

3 years ago
Sure, throw in the template too. But the ONLY string we need to localize in the templates is "View All Apps". Though, Scott only mentioned brands.
(Assignee)

Updated

3 years ago
Assignee: ddurst → kngo
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/fireplace/pull/560

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 5

3 years ago
https://github.com/mozilla/fireplace/commit/9d2014de2dc682edb2f9a1ee690cb25c87483824
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.