1052722 - Running Gaia in Desktop Firefox not working properly in Nightly build 34.0a1 (2014-08-12)

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[varghesethomase]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140726030204

Steps to reproduce:


Followed the steps given in the following link to run Gaia in Desktop Firefox nightly build 34.0a1. 
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Running_the_Gaia_codebase

cd gaia
DEBUG=1 make
/path/to/firefoxnightly -profile /path/to/B2G/gaia/profile-debug -no-remote

(Even after downloading a fresh gaia build thinking it would be error in previous git code, the error persists. But on reverting back to an older version of Nightly build bug gets fixed)


Actual results:

The Gaia runs in Nightly. But no apps are launched on clicking over the icons. 




Expected results:

Apps get launched once the icons are clicked.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Confirmed, this is bugging me too, I'll have a look tomorrow to see what's wrong. What bugs me even more is that I already fixed a bug that prevented Gaia from working in desktop Firefox less than two weeks ago and it's broken once again :/

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

Facing the same issue. Would love to see this fixed really quick :)

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

I did some investigation on this thinking this might be a gaia problem like it happened in the past but it seems that it isn't. After clicking on an icon the App.launch() method is correctly called but the application doesn't launch so I think this might be a Gecko issue. I'll try to do a bisection today to identify what regressed this behavior.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

After a long bisection I've found that the issue was caused by bug 1042881, this is the offending changeset: http://hg.mozilla.org/mozilla-central/rev/83532407ecf9

I haven't had time to investigate why it's happening yet, CC'ing :fabrice since he wrote the patch for that bug.

Comment 6

[Kevin Grandon :kgrandon]

Fabrice - this is causing a bunch of our third party developers a lot of pain. Any clues as to why bug 1042881 would've broken app launching in Firefox desktop?

Comment 7

[Kevin Grandon :kgrandon]

Nevermind, I think I've figured it out.

Comment 8

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8485431 [details] [review]
Github pull request

Hey guys - anyone got time for a quick review stamp? Thanks!

Comment 10

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/f38a19342936ea60d2e7eb64e8cf070b9219edf2
V2.0 (a=nbotb): https://github.com/mozilla-b2g/gaia/commit/a8e4d26555e5713ec6c72270cfd0cfabc096a0d3