1052751 - Trivial fullscreen app causes 300% overdraw on Flame v2.0

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: app.zip

As identified by the regression window: http://goo.gl/PsAzqE

It looks like b2g master hit 200% overdraw on this app (before this was regressed) but it looks like this optimization never made it into v2.0. We should find out if it's possible to uplift that optimization into v2.0.

But it also looks like this is not a regression so it's likely not required that we block the v2.0 release on this fix.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Layer tree + custom culling log

We don't perform culling on the app's reflayer because it has a NonIdentify transform caused by the viewport.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: Part 1: Cull translated layers

Building on your work to perform simple culling in the compositor.

Comment 3

[Botond Ballo [:botond]]

Comment on attachment 8472585 [details] [diff] [review]
Part 1: Cull translated layers

Review of attachment 8472585 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +334,4 @@
>      }
>    }
>  
> +#ifdef CULL_LOGGING

You might want to consider enabling the logging the way we do it in APZ, see e.g.:

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/APZCTreeManager.cpp?rev=4b96541d8a0d#28

Comment 4

[Benoit Girard (:BenWa)]

Attachment: Part 1: Cull translated layers

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Part 1: Cull translated layers v2

This gets the settings app overdraw to 100-130%.

Comment 6

[Benoit Girard (:BenWa)]

This has an interaction with the overscroll since I'm using the base transform. We talked about a similar problem botond recently. Let's chat tomorrow.

Comment 7

[Benoit Girard (:BenWa)]

remote:   https://tbpl.mozilla.org/?tree=Try&rev=5b427405f581
remote: Alternatively, view them on Treeherder (experimental):
remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5b427405f581

Comment 8

[Benoit Girard (:BenWa)]

Turns out that my patch does change the overscroll in cases where the app incorrectly got the right over scroll color from an unrelated layer. My patch just changes the undefined behavior cases.

Comment 9

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/926c83cd24f0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G reftest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b3ddcde7580

https://tbpl.mozilla.org/php/getParsedLog.php?id=46064189&tree=Mozilla-Inbound

Comment 11

[Benoit Girard (:BenWa)]

Attachment: Part 1: Cull translated layers v2

Disabling for fixed/sticky position layer:

https://tbpl.mozilla.org/?tree=Try&rev=bcd2a260cd0d

Comment 12

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e2e0518a548

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6e2e0518a548

Comment 14

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.