Closed Bug 1052758 Opened 6 years ago Closed 6 years ago

ipc/chromium/src/base/message_pump_glib.cc:20:12: warning: unused variable 'kWorkScheduled' [-Wunused-const-variable]

Categories

(Core :: IPC, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning:
{
 1:18.57 $SRCDIR/ipc/chromium/src/base/message_pump_glib.cc:20:12: warning: unused variable 'kWorkScheduled' [-Wunused-const-variable]
 1:18.57 const char kWorkScheduled = '\0';
 1:18.57            ^
}

This variable has existed, unused, since the initial import of this file:
http://hg.mozilla.org/mozilla-central/rev/6fd4bb500d42#l218.21

We should just drop it.
(I'm building with clang 3.5, FWIW.)
Attached patch fixSplinter Review
Attachment #8471824 - Flags: review?(ehsan)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(This file has been mostly-untouched since it was imported:
http://hg.mozilla.org/mozilla-central/filelog/0c7eb00d3ef6/ipc/chromium/src/base/message_pump_glib.cc
so I don't think there's any strong ownership over it. Hence, tagging ehsan as a sane, reliable reviewer. :))
Attachment #8471824 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/04d0aea75267
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.