1052758 - ipc/chromium/src/base/message_pump_glib.cc:20:12: warning: unused variable 'kWorkScheduled' [-Wunused-const-variable]

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
 1:18.57 $SRCDIR/ipc/chromium/src/base/message_pump_glib.cc:20:12: warning: unused variable 'kWorkScheduled' [-Wunused-const-variable]
 1:18.57 const char kWorkScheduled = '\0';
 1:18.57            ^
}

This variable has existed, unused, since the initial import of this file:
http://hg.mozilla.org/mozilla-central/rev/6fd4bb500d42#l218.21

We should just drop it.

Comment 1

[Daniel Holbert [:dholbert]]

(I'm building with clang 3.5, FWIW.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 3

[Daniel Holbert [:dholbert]]

(This file has been mostly-untouched since it was imported:
http://hg.mozilla.org/mozilla-central/filelog/0c7eb00d3ef6/ipc/chromium/src/base/message_pump_glib.cc
so I don't think there's any strong ownership over it. Hence, tagging ehsan as a sane, reliable reviewer. :))

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04d0aea75267

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/04d0aea75267