105276 - Duplicate attachment file dialog does not show up

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Jean-Francois Ducarroz]

When you try to attach twice the same attachment, we are suppose to show an
alert. But this one does not show up because of a JS error. The strings we are
looking for  are missing: DuplicateFileErrorDlogTitle &
DuplicateFileErrorDlogMessage

Comment 1

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 2

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 3

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 4

[klonos]

still on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Shredder/3.0b1pre Mnenhy/0.7.5.666 - Build ID: 20090226032557

Comment 5

[Thomas D. (:thomas8)]

Current Trunk checks for duplicate attachments and by design, just continues without error message (which I think is reasonable):

http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#3681

3680     if (!(attachment && attachment.url) ||
3681         DuplicateFileAlreadyAttached(attachment.url))
3682       continue;

However, I wonder how this interacts with the various more or less unpredictable states that a file attachment is going through (also depending on the method of attaching), along the lines of Bug 378046 Comment 60.