Closed Bug 1052813 Opened 6 years ago Closed 6 years ago

[Skia] Doesn't build with --disable-optimize on ARM

Categories

(Core :: Graphics, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: gw280, Assigned: gw280)

References

Details

Attachments

(1 file)

/Volumes/fennec/gecko-dev/gfx/skia/trunk/src/opts/SkBlitRow_opts_arm.cpp: In function 'void S32A_D565_Opaque(uint16_t*, const SkPMColor*, int, U8CPU, int, int)':
/Volumes/fennec/gecko-dev/gfx/skia/trunk/src/opts/SkBlitRow_opts_arm.cpp:114:1: error: r7 cannot be used in asm here
make[5]: *** [Unified_cpp_gfx_skia20.o] Error 1

The solution here is to add -fomit-frame-pointer to our CXXFLAGS (which is added by default in gcc's optimised builds).
Attachment #8471863 - Flags: review?(snorp) → review?(matt.woodrow)
Attachment #8471863 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/fc99f1aac290
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Depends on: 1154347
You need to log in before you can comment on or make changes to this bug.