Closed Bug 1052855 Opened 6 years ago Closed 6 years ago

Traces link to a first line of a function instead of the function declaration

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: jjurovych, Assigned: jjurovych)

References

Details

Attachments

(1 file, 2 obsolete files)

Tracer most of the time (not always) interprets a location of a frame to be the first line inside a function's body instead of the function's declaration.
Blocks: 949754
Attached patch bug-1052855.patch (obsolete) — Splinter Review
Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8600cf4202d2
Assignee: nobody → jjurovych
Attachment #8474973 - Flags: review?(nfitzgerald)
Attached patch bug-1052855-2.patch (obsolete) — Splinter Review
Fixed tests.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d41dc950e0a7
Attachment #8474973 - Attachment is obsolete: true
Attachment #8474973 - Flags: review?(nfitzgerald)
Attachment #8474996 - Flags: review?(nfitzgerald)
More test-fixing.
Attachment #8474996 - Attachment is obsolete: true
Attachment #8474996 - Flags: review?(nfitzgerald)
Attachment #8475481 - Flags: review?(nfitzgerald)
Attachment #8475481 - Flags: review?(nfitzgerald) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/68d1093896b1
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.