1052884 - webrtc prompt code uses uri.host without try/catch or checks

Status: RESOLVED INVALID

(Firefox :: Site Permissions, defect)

Description

[:Gijs (he/him)]

Noticed this when working on bug 1043372. See:

http://mxr.mozilla.org/mozilla-central/source/browser/modules/webrtcUI.jsm#180

I actually noticed errors from this line in my test output when running the tests at: http://mxr.mozilla.org/mozilla-central/find?string=_devices . Not sure why.

I'm fairly sure this is Not Good, although I'm not sure if this is just a straight dupe of bug 801066... or not.

Comment 1

[Florian Quèze [:florian]]

We actually used to have a try/catch there, and we removed it because about:loopconversation is never supposed to prompt now that it's whitelisted in the C++ code.

The error you are seeing when running the test likely happens when we test that about:evil isn't whitelisted: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser_devices_get_user_media_about_urls.js#204

Comment 2

[Emma Zühlcke [:emz]]

The only uri.host access I could find in the current WebRTC frontend code is here: https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/browser/modules/webrtcUI.jsm#751 and that has a try-catch. Closing.