1052907 - The --this-chunk and --total-chunk arguments to "mach reftest-remote" don't work

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The --this-chunk and --total-chunk arguments to "mach reftest-remote" don't work because they're stored as strings rather than ints, and thus written to the prefs file as strings rather than ints.

Patch coming shortly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Make --this-chunk and --total-chunks arguments to mach reftest-remote work by coercing them to ints, which they need to be

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I'd note that the arguments do work for "mach reftest".  I was tempted to make the same change there despite that, though.   If there's ongoing work to pass more stuff around within python rather than invoking other python scripts, that might incline me more towards doing so.)

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8471959 [details] [diff] [review]
Make --this-chunk and --total-chunks arguments to mach reftest-remote work by coercing them to ints, which they need to be

Review of attachment 8471959 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c57732433b20

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c57732433b20