1052941 - test-agent hiccups with sinon error after test where sinon wasn't used

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

I have a test here https://github.com/gaye/gaia/blob/bug-1023644/apps/calendar/test/unit/provider/provider_test.js that fails with the following error even though I never used sinon. Agh!  

3) [calendar-test/unit/provider/provider_test.js]  "after each" hook:
     TypeError: this.sinon is null
      at (anonymous) (app://calendar.gaiamobile.org/common/test/sinon_helper.js:8:5)
      at wrapper (app://calendar.gaiamobile.org/common/test/mocha_generators.js:62:19)
      at run (app://calendar.gaiamobile.org/common/vendor/mocha/mocha.js:3709:7)
      at next (app://calendar.gaiamobile.org/common/vendor/mocha/mocha.js:3973:5)
      at (anonymous) (app://calendar.gaiamobile.org/common/vendor/mocha/mocha.js:3984:5)
      at (anonymous) (app://calendar.gaiamobile.org/common/vendor/mocha/mocha.js:4932:28)

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22806

Ahhhhhhhhhh

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8472000 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22806

I wanted to do that for such a long time.
Thanks :p

Comment 3

[Julien Wajsberg [:julienw]]

master: 0918e40d19e2bc1e8cc6be70f864aca64dbe3b3d