Closed Bug 1052985 Opened 5 years ago Closed 5 years ago

Fix windows manifest build issues

Categories

(MailNews Core :: Build Config, defect, critical)

defect
Not set
critical

Tracking

(thunderbird34 fixed)

RESOLVED FIXED
Thunderbird 34.0
Tracking Status
thunderbird34 --- fixed

People

(Reporter: iann_bugzilla, Assigned: jcranmer)

References

Details

Attachments

(1 file, 1 obsolete file)

Since the landing of the fix to bug 1035599 window builds have failed due to not being able to find the manifest file.
This patch seems to fix it (green on try) but not sure if it is the correct fix.
Attachment #8472011 - Flags: review?(Pidgeot18)
Comment on attachment 8472011 [details] [diff] [review]
Use the same winsrc on all platforms

Review of attachment 8472011 [details] [diff] [review]:
-----------------------------------------------------------------

After investigating the issue more thoroughly, I found what appears to be the real problem:

We used to rely on a munged config.status for the comm-central config/autoconf.mk generation. That isn't happening anymore, but with pseudo-rework it is drastically less needed.

I think I have a fix for this, let me go test it.
Attachment #8472011 - Flags: review?(Pidgeot18) → review-
Assignee: iann_bugzilla → Pidgeot18
Attachment #8472011 - Attachment is obsolete: true
Attachment #8472086 - Flags: review?(standard8)
Comment on attachment 8472086 [details] [diff] [review]
Tweak WIN_TOP_SRC path in baseconfig.mk

Looks reasonable to me. r=Standard8
Attachment #8472086 - Flags: review?(standard8) → review+
https://hg.mozilla.org/comm-central/rev/f299fe99916d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.