1052985 - Fix windows manifest build issues

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ian Neal]

Attachment: Use the same winsrc on all platforms

Since the landing of the fix to bug 1035599 window builds have failed due to not being able to find the manifest file.
This patch seems to fix it (green on try) but not sure if it is the correct fix.

Comment 1

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8472011 [details] [diff] [review]
Use the same winsrc on all platforms

Review of attachment 8472011 [details] [diff] [review]:
-----------------------------------------------------------------

After investigating the issue more thoroughly, I found what appears to be the real problem:

We used to rely on a munged config.status for the comm-central config/autoconf.mk generation. That isn't happening anymore, but with pseudo-rework it is drastically less needed.

I think I have a fix for this, let me go test it.

Comment 2

[Joshua Cranmer [:jcranmer]]

Attachment: Tweak WIN_TOP_SRC path in baseconfig.mk

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8472086 [details] [diff] [review]
Tweak WIN_TOP_SRC path in baseconfig.mk

Looks reasonable to me. r=Standard8

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/f299fe99916d