1053007 - Mozilla's "Lightbeam" add-on's buttons do not work with e10s

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Install the Lightbeam addon: https://addons.mozilla.org/en-US/firefox/addon/lightbeam
2. In an e10s window, open the Lightbeam UI from "Tools" menu > "Show Lightbeam" menu item
3. The Lightbeam UI is displayed, but none of the buttons (such as "CONTRIBUTE DATA") work.
4. The Lightbeam UI in a non-e10s window and the buttons work correctly.

The following error message is logged to the Browser Console:

chrome://browser/content/browser.xul : Unable to run script because scripts are blocked internally.

Comment 1

[Chris Peterson [:cpeterson]]

François: do you maintain Lightbeam?

It is not e10s-compatible. The Lightbeam UI's buttons do not work and the first run page is blank and the browser console reports:

> NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURI] browser-child.js:192

If you have any questions about add-on support for multiprocess Firefox (e10s), just drop by the #e10s IRC channel on irc.mozilla.org. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Comment 2

[François Marier [:francois]]

Chris: I do. It's not very high on my priority list, but I'll try to take a look and see if it's easy to fix.

Comment 3

[François Marier [:francois]]

Chris: you may want to flag Lightbeam as "not working" on arewee10syet.com because while the button and the UI show up, none of the in-content JS runs.

Comment 4

[Chris Peterson [:cpeterson]]

Thanks. I'll update the website to point to this open bug.

Comment 5

[Nicholas Nethercote [inactive]]

FYI: Lightbeam is currently broken by non-e10s problems (specifically, its use of |const|). See https://github.com/mozilla/lightbeam/issues/622.

Comment 6

[François Marier [:francois]]

Unassigning myself because I'm not actively looking at this.

Comment 7

[Allison Naaktgeboren :ally]

According to e10s telemetry data, lightbeam regularly throws an exception in policy.js on line 94

Comment 8

[Edwin Wong [:edwong]]

It would be great to insert a banner on the lightbeam page to inform users to open in a non-e10s window... till this is fixed.

Comment 9

[François Marier [:francois]]

The new nsISimpleContentPolicy (introduced in bug 1128798) might be useful: https://hg.mozilla.org/mozilla-central/file/9ba87714f5cf/dom/base/nsISimpleContentPolicy.idl

Comment 10

[Jerod Lycett]

It mostly seems to be working except one oddity. It doesn't track anything in e10s.

Comment 12

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Assignee: Bill McCloskey
Link to add-on: https://addons.mozilla.org/en-Us/firefox/addon/lightbeam/
Contact info for add-on:
https://github.com/mozilla/lightbeam
:francois at Mozilla
Add-on ID: jid1-F9UJ2thwoAm5gQ
How well does it work?: 10%
Steps to reproduce working features:
It pops up a help window on installation and the toolbar button goes to the right page.
Steps to reproduce broken features:
- No data is tracked or displayed in e10s.
- Lots of aRequestOrigin is null errors in the console
Any obvious performance problems?
Yes. Add-on slowness monitor pops up frequently.
SDK-based: Yes
Chromium version: No

Comment 13

[Andy McKay]

With some changes, including https://github.com/mozilla/lightbeam/pull/698, it now works in e10s, pulling the version from github. I did notice at least one aRequestOrigin is null errors in the console and it could be a bit faster, but it works now and that's the main thing.

Comment 14

[Andy McKay]

Marking resolved fixed based on the fact that it seems to work.