Closed Bug 1053033 Opened 5 years ago Closed Last year

Use webidl dictionaries for the manifests properties

Categories

(Core Graveyard :: DOM: Apps, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: fabrice, Assigned: fabrice)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → fabrice
Depends on: 963382
Blocks: 899322
Does this bug include fixing DOMApplication.receipts or does that need a separate bug?
Flags: needinfo?(fabrice)
I'm not sure. receipts are |sequence<DOMString>| so that may need different binding support? If not, I'll wrap everything in this bug.
Flags: needinfo?(fabrice)
Bug 963382 will apply to sequences as well as dictionaries.
Looks like the dep was fixed. Let us know if you need anything else, Fabrice. Thanks for doing this!
Flags: needinfo?(fabrice)
Attached patch Part 1: receiptsSplinter Review
That's the easy part!
Attachment #8483676 - Flags: review?(mar.castelluccio)
Flags: needinfo?(fabrice)
Attachment #8483676 - Flags: review?(mar.castelluccio) → review+
I'm moving the receipts patch into bug 1063852 because the manifest conversion is not so simple. I need to dig a bit more but it seems that we hit some limitations of our current bindings implementation.
(In reply to Fabrice Desré [:fabrice] from comment #6)
> I'm moving the receipts patch into bug 1063852 because the manifest
> conversion is not so simple. I need to dig a bit more but it seems that we
> hit some limitations of our current bindings implementation.

Please file bugs! We will fix them promptly. ;-)
(In reply to Bobby Holley (:bholley) from comment #7)
> (In reply to Fabrice Desré [:fabrice] from comment #6)
> > I'm moving the receipts patch into bug 1063852 because the manifest
> > conversion is not so simple. I need to dig a bit more but it seems that we
> > hit some limitations of our current bindings implementation.
> 
> Please file bugs! We will fix them promptly. ;-)

I'm blocked on bug 767924 because the manifests have an "orientation" property that can be either a Orientation or a sequence<Orientation> (Orientation is a enum of strings).

I'm working on getting a reduced test case for the other issue I'm having, and will file.
Depends on: 767924
(In reply to Fabrice Desré [:fabrice] from comment #8)
> (In reply to Bobby Holley (:bholley) from comment #7)
> > (In reply to Fabrice Desré [:fabrice] from comment #6)
> > > I'm moving the receipts patch into bug 1063852 because the manifest
> > > conversion is not so simple. I need to dig a bit more but it seems that we
> > > hit some limitations of our current bindings implementation.
> > 
> > Please file bugs! We will fix them promptly. ;-)
> 
> I'm blocked on bug 767924 because the manifests have an "orientation"
> property that can be either a Orientation or a sequence<Orientation>
> (Orientation is a enum of strings).

That bug appears to be fixed, so I don't fully understand what it means to be blocked on it.

> I'm working on getting a reduced test case for the other issue I'm having,
> and will file.

Works for me!
Depends on: 1063889
No longer depends on: 767924
Depends on: 1068491
Product: Core → Core Graveyard
Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.