1053033 - Use webidl dictionaries for the manifests properties

Status: RESOLVED WONTFIX

(Core Graveyard :: DOM: Apps, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Does this bug include fixing DOMApplication.receipts or does that need a separate bug?

Comment 2

[[:fabrice] Fabrice Desré]

I'm not sure. receipts are |sequence<DOMString>| so that may need different binding support? If not, I'll wrap everything in this bug.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Bug 963382 will apply to sequences as well as dictionaries.

Comment 4

[Bobby Holley (:bholley)]

Looks like the dep was fixed. Let us know if you need anything else, Fabrice. Thanks for doing this!

Comment 5

[[:fabrice] Fabrice Desré]

Attachment: Part 1: receipts

That's the easy part!

Comment 6

[[:fabrice] Fabrice Desré]

I'm moving the receipts patch into bug 1063852 because the manifest conversion is not so simple. I need to dig a bit more but it seems that we hit some limitations of our current bindings implementation.

Comment 7

[Bobby Holley (:bholley)]

(In reply to Fabrice Desré [:fabrice] from comment #6)
> I'm moving the receipts patch into bug 1063852 because the manifest
> conversion is not so simple. I need to dig a bit more but it seems that we
> hit some limitations of our current bindings implementation.

Please file bugs! We will fix them promptly. ;-)

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Bobby Holley (:bholley) from comment #7)
> (In reply to Fabrice Desré [:fabrice] from comment #6)
> > I'm moving the receipts patch into bug 1063852 because the manifest
> > conversion is not so simple. I need to dig a bit more but it seems that we
> > hit some limitations of our current bindings implementation.
> 
> Please file bugs! We will fix them promptly. ;-)

I'm blocked on bug 767924 because the manifests have an "orientation" property that can be either a Orientation or a sequence<Orientation> (Orientation is a enum of strings).

I'm working on getting a reduced test case for the other issue I'm having, and will file.

Comment 9

[Bobby Holley (:bholley)]

(In reply to Fabrice Desré [:fabrice] from comment #8)
> (In reply to Bobby Holley (:bholley) from comment #7)
> > (In reply to Fabrice Desré [:fabrice] from comment #6)
> > > I'm moving the receipts patch into bug 1063852 because the manifest
> > > conversion is not so simple. I need to dig a bit more but it seems that we
> > > hit some limitations of our current bindings implementation.
> > 
> > Please file bugs! We will fix them promptly. ;-)
> 
> I'm blocked on bug 767924 because the manifests have an "orientation"
> property that can be either a Orientation or a sequence<Orientation>
> (Orientation is a enum of strings).

That bug appears to be fixed, so I don't fully understand what it means to be blocked on it.

> I'm working on getting a reduced test case for the other issue I'm having,
> and will file.

Works for me!

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Core Graveyard / DOM: Apps is inactive. Closing all bugs in this component.