1053034 - Convert components to use multi-line strings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

Multi-line strings just landed and this should clean up our javascript quite a bit. Let's try using them in components as a PoC.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

We need JSHint to allow both single quotes and TemplateLiterals, or we get an error: Strings must use singlequote. (ERROR)

I've filed an issue here: https://github.com/jshint/jshint/issues/1797

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8472092 [details] [review]
Github pull request

This is exciting, we get to use mutli-line template literals now, woot.

Wilson or Doug - could either of you spend some time to review this? I'd like to start introducing TemplateLiterals to gaia, and web components make sense as a good first start.

Comment 4

[Wilson Page [:wilsonpage]]

Comment on attachment 8472092 [details] [review]
Github pull request

Looks sweet! Would it now make sense just to bundle our CSS into the template too, like an html-import? Would avoid all the issues we have with the current `@import()` hackiness.

My only concern here is that our components will only work in ES6 engines. I guess if need, be we could transpile an ES5 version is there was demand.

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Wilson Page [:wilsonpage] from comment #4)
> Looks sweet! Would it now make sense just to bundle our CSS into the
> template too, like an html-import? Would avoid all the issues we have with
> the current `@import()` hackiness.

Thanks for the review. I would prefer to keep the CSS inside of css files for syntax goodness personally, but we can explore it as an option.

Comment 6

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/216dc181604f3e7ad2d103e130c814836ebe0d0c