1053041 - [Tracking] Dissect Input Management Script (keyboard_manager.js)

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Let's dissect Input Management module (keyboard_manager.js), into more manageable and testable chunks.

This extends the prior related efforts: bug 1043121 extracts IMESwitcher-related functionalities, and bug 1044744 extracts keyboard frame management logics (both of them have landed).
 
Things envisioned that will follow those two bugs:
1. Extract the anonymous callbacks from ImeMenu in |KeyboardManager.showAll()| to separate, testable functions.

2. Extract inner functions in |KeyboardManager.updateLayouts()|. Also, perhaps split |updateLayouts()| into smaller chunks, as larger functions tend to be more difficult to (unit) test.

3. Extract the inner function in |KeyboardManager.inputFocusChange()|.

If suitable, let's put the extracted and logically groupable codes into separate modules.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I assume this depends on bug 1074749 and blocks bug 971509.

Comment 2

[BMO Automation]

Firefox OS is not being worked on