Closed Bug 1053041 Opened 9 years ago Closed 5 years ago

[Tracking] Dissect Input Management Script (keyboard_manager.js)

Categories

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mnjul, Unassigned)

References

Details

Let's dissect Input Management module (keyboard_manager.js), into more manageable and testable chunks.

This extends the prior related efforts: bug 1043121 extracts IMESwitcher-related functionalities, and bug 1044744 extracts keyboard frame management logics (both of them have landed).
 
Things envisioned that will follow those two bugs:
1. Extract the anonymous callbacks from ImeMenu in |KeyboardManager.showAll()| to separate, testable functions.

2. Extract inner functions in |KeyboardManager.updateLayouts()|. Also, perhaps split |updateLayouts()| into smaller chunks, as larger functions tend to be more difficult to (unit) test.

3. Extract the inner function in |KeyboardManager.inputFocusChange()|.

If suitable, let's put the extracted and logically groupable codes into separate modules.
Depends on: 1053624
Depends on: 1054942
Depends on: 1058382
Depends on: 1059663
Depends on: 1059668
Depends on: 1063457
Depends on: 1063461
I assume this depends on bug 1074749 and blocks bug 971509.
Depends on: input-window
Depends on: 1111438
Depends on: 1112495
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.