mozbuild.util.ReadOnlyDefaultDict doesn't throw on update()

RESOLVED FIXED in mozilla34

Status

Firefox Build System
General
RESOLVED FIXED
4 years ago
5 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla34

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8472159 [details] [diff] [review]
Make mozbuild.util.ReadOnlyDefaultDict raise an exception on update()
Attachment #8472159 - Flags: review?(gps)
(Assignee)

Comment 2

4 years ago
Created attachment 8472229 [details] [diff] [review]
Make mozbuild.util.ReadOnlyDefaultDict raise an exception on update() and del

While at it, let's add __delitem__ too.
Attachment #8472229 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Blocks: 1053140

Updated

4 years ago
Attachment #8472229 - Flags: review?(gps) → review+

Updated

4 years ago
Attachment #8472159 - Attachment is obsolete: true
Attachment #8472159 - Flags: review?(gps)
https://hg.mozilla.org/mozilla-central/rev/9ab7126c7cba
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.