Simplify EXTERNAL_SOURCE_DIR handling

RESOLVED FIXED in mozilla34

Status

Firefox Build System
General
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla34
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8472166 [details] [diff] [review]
Simplify EXTERNAL_SOURCE_DIR handling

As handled in configure.in, EXTERNAL_SOURCE_DIR is a single directory for
external sources, and more specifically, comm-central. There is no need
to handle it as a list in the moz.build emitter.

At the same time, avoid checking the external sources for every moz.build,
and bind it to a config environment.
Attachment #8472166 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Blocks: 1053085
(Assignee)

Updated

4 years ago
Blocks: 1053140

Comment 2

4 years ago
Comment on attachment 8472166 [details] [diff] [review]
Simplify EXTERNAL_SOURCE_DIR handling

Review of attachment 8472166 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/reader.py
@@ +181,5 @@
>              if filesystem_absolute:
>                  return path
> +            roots = [self.topsrcdir]
> +            if self.config.external_source_dir:
> +                roots += [self.config.external_source_dir]

Nit: The convention is |l.append(x)|, since += forces the creation of extra garbage.
Attachment #8472166 - Flags: review?(gps) → review+
(Assignee)

Comment 3

4 years ago
Landed with a fixup in python/mozbuild/mozbuild/test/common.py for Windows tests.
https://hg.mozilla.org/integration/fx-team/rev/0ae7262449d8
Whiteboard: [fixed-in-fx-team]

Comment 4

4 years ago
https://hg.mozilla.org/mozilla-central/rev/0ae7262449d8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.