Improve mozbuild.util.memoize and add memoized_property

RESOLVED FIXED in mozilla34

Status

RESOLVED FIXED
4 years ago
8 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla34
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8472176 [details] [diff] [review]
Improve mozbuild.util.memoize and add memoized_property
Attachment #8472176 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Blocks: 1053085
(Assignee)

Updated

4 years ago
Blocks: 1053140

Comment 2

4 years ago
Comment on attachment 8472176 [details] [diff] [review]
Improve mozbuild.util.memoize and add memoized_property

Review of attachment 8472176 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/test/test_util.py
@@ +483,5 @@
> +        # same type should give us the same id.
> +        instance_id = id(instance)
> +        del instance
> +        instance = foo()
> +        self.assertEqual(instance_id, id(instance))

I /think/ this is a CPython implementation detail (objects are refcounted and destroyed immediately). Meh.
Attachment #8472176 - Flags: review?(gps) → review+

Comment 4

4 years ago
https://hg.mozilla.org/mozilla-central/rev/44b0dcb52a8c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
QA Whiteboard: [qa-]

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.