1053164 - Exceptions are trapped during actors loading

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

While I was working on making the actors being lazy loaded, I realized a pretty significant codepath like DebuggerServer.addBrowserActors() have its exception being trapped and ignored by promises. No output in stdout nor the js console.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8472291 [details] [diff] [review]
patch

Review of attachment 8472291 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!  I bet you could find many more issues just like this one if you look hard enough... :/

Comment 3

[Alexandre Poirot [:ochameau]]

https://tbpl.mozilla.org/?tree=Try&rev=5aed22a43ec1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a855508f7cbc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a855508f7cbc