Closed Bug 1053181 Opened 10 years ago Closed 10 years ago

The standalone pages don't display images on the dev server

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox34 verified)

VERIFIED FIXED
mozilla34
Tracking Status
firefox34 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: regression)

Attachments

(1 file)

Testing on the dev server, I realised that the standalone pages aren't displaying the images that they should do.

This is down to the relative paths we're putting in the css, that assume that our version of the standalone server is run.
This fixes the paths - the dev (and other servers) don't have the content/ directory that our standalone test server has. Hence, the relative paths are wrong there.

I was thinking about how we could stop this happening, and I think it really comes down to restructuring our test server to not have the content/ directory - which is probably a little bit more work, and deserves a separate bug.
Attachment #8472319 - Flags: review?(dmose)
Comment on attachment 8472319 [details] [diff] [review]
Fix Loop's standalone pages to display correctly on the proper dev server. NPOTB DONTBUILD

Assuming this continues to work with the dev server, r=dmose.
Attachment #8472319 - Flags: review?(dmose) → review+
By which I meant "local development server".
(In reply to Dan Mosedale (:dmose - needinfo? me for responses) from comment #2)
> Assuming this continues to work with the dev server, r=dmose.

Yep, they are fine.

https://hg.mozilla.org/integration/fx-team/rev/9c62e270aff6
https://hg.mozilla.org/mozilla-central/rev/9c62e270aff6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Does this need manual testing? If so, can I please get steps to reproduce?
Flags: qe-verify?
Mark, can you please answer comment 6?
Flags: needinfo?(standard8)
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #6)
> Does this need manual testing? If so, can I please get steps to reproduce?

In theory this would have happened on the production server as well, had we not caught it in time. So the STR would be:

- Open up a call url in a tab
- Check all the expected images are displayed.

You can also test against the dev server by setting loop.server preference to "https://loop-dev.stage.mozaws.net" (no trailing slash), and restarting, before generating the call url.
Flags: needinfo?(standard8)
Flags: qe-verify? → qe-verify+
The correct images seem to be displaying so I'm marking this verified fixed.
Status: RESOLVED → VERIFIED
QA Contact: anthony.s.hughes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: