Created attachment 8472321 [details] [diff] [review] AudioOffloadPlayer-avoid-startup-glitch.patch [Blocking Requested - why for this release]: Customer issue Minor glitch observed from 0 to 0.2 seconds during playback of mp3 clip in offlaod mode. Analysis -------- 1. We figure out whether platform supports offloading in MediaOMXReader  2. Based on that info, MediaOmxDecoder pauses the state machine and starts AudioOffloadPlayer  3. In between  and , if MediaDecoderStateMachine::StartPlayback() is started, then minor glitch is observed while switching from non offlaod to offload mode. Suggested Fix ------------- Attached patch (v1.4) makes MediaDecoderStateMachine::StartPlayback() a noop if audio offloading is possible to avoid the glitch. Will upload V2.0 fix once the V1.4 fix is accepted.  http://dxr.mozilla.org/mozilla-central/source/content/media/omx/MediaOmxReader.cpp#457  http://dxr.mozilla.org/mozilla-central/source/content/media/omx/MediaOmxDecoder.cpp#79
vasanth: I think this is better going straight to 2.0 since that's where this is required by the launching partner. 1.4 does not need this.
Created attachment 8472906 [details] [diff] [review] AudioOffloadPlayer-avoid-startup-glitch.patch Updated patch sets mFallbackToStateMachine to true in one more error case.
(In reply to Wayne Chang [:wchang] from comment #1) > vasanth: > I think this is better going straight to 2.0 since that's where this is > required by the launching partner. > 1.4 does not need this. Customer raised this issue to us on 1.4 Moving ni to him
Attachment #8472906 - Flags: review?(roc) → review+
(v2.0 would be where this is needed ultimately, we don't really need this to land in upstream v1.4)
blocking-b2g: 1.4? → 2.0?
No STR is present to create test case to address bug.
QA Whiteboard: [QAnalyst-Triage?]
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage?][2.0-signoff-need+]
(In reply to Yeojin Chung [:YeojinC] from comment #5) > No STR is present to create test case to address bug. 1. In MSM platforms (Ex: Flame, QRD8x10) play any .mp3 music file. 2. It would result in offload playback (From logcat, AuidoFlinger will show compress-offload-playback logs. Not sure if there is any other way to find this) 3. Without this patch we can hear a minor glitch during song start up. You can spot the difference by playing same clip with this path or in VLC. Let me know if you need more info. (In reply to Michael Vines [:m1] [:evilmachines] from comment #4) > (v2.0 would be where this is needed ultimately, we don't really need this to > land in upstream v1.4) Thanks! Will upload a patch for 2.0
Test case added in moztrap: https://moztrap.mozilla.org/manage/case/14339/
QA Whiteboard: [QAnalyst-Triage?][2.0-signoff-need+] → [QAnalyst-Triage+][2.0-signoff-need+]
Created attachment 8474524 [details] [diff] [review] AudioOffloadPlayer-avoid-startup-glitch-V2.0.patch
Created attachment 8474525 [details] [diff] [review] AudioOffloadPlayer-avoid-startup-glitch-V2.1.patch Rebased the patch for V2.0 AND V2.1
Attachment #8474525 - Flags: review+
(In reply to vasanth from comment #10) > 2.1 - https://tbpl.mozilla.org/?tree=Try&rev=3bdecf4857b0 2.1 try build failed. My bad with using hg. Started new 2.1 try run https://tbpl.mozilla.org/?tree=Try&rev=8e9d579217a1
Try runs seems good now. starred failures. Adding checkin-needed
Patch for Mozilla-Central - AudioOffloadPlayer-avoid-startup-glitch-V2.1.patch Patch for 2.0 - AudioOffloadPlayer-avoid-startup-glitch-V2.0.patch
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
status-firefox32: --- → wontfix
status-firefox33: --- → wontfix
status-firefox34: --- → fixed
You need to log in before you can comment on or make changes to this bug.