Thunderbird ship-it notifications have wrong mozilla-beta revision

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: sylvestre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Just submitted a build to ship-it, and we got this on thunderbird-drivers:

======
A new build has been submitted through ship-it:
mozilla commit: https://hg.mozilla.org/releases/mozilla-beta/rev/98d598127699
comm commit: https://hg.mozilla.org/releases/comm-beta/rev/98d598127699
======

The mozilla-beta rev should have been https://hg.mozilla.org/releases/mozilla-beta/rev/8bf5700cb82e
(Assignee)

Updated

5 years ago
Assignee: nobody → sledru
(Assignee)

Comment 1

5 years ago
Created attachment 8472999 [details] [diff] [review]
0001-Bug-1053195-same-m-c-c-b-changeset-in-the-email.patch
Attachment #8472999 - Flags: review?(bhearsum)
(Assignee)

Updated

5 years ago
Attachment #8472999 - Flags: review?(rail)

Comment 2

5 years ago
Comment on attachment 8472999 [details] [diff] [review]
0001-Bug-1053195-same-m-c-c-b-changeset-in-the-email.patch

Review of attachment 8472999 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.py
@@ +220,5 @@
> +        if name == "comm":
> +            # Thunderbird
> +            revision=r["commRevision"]
> +        else:
> +            revision=r["mozillaRevision"]

A nit. Can you add spaces around "=" when you land?
Attachment #8472999 - Flags: review?(rail)
Attachment #8472999 - Flags: review?(bhearsum)
Attachment #8472999 - Flags: review+
(Reporter)

Comment 4

5 years ago
Thanks Sylvestre, these are great improvements to ship-it :-)

Comment 5

5 years ago
In production
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.