1053195 - Thunderbird ship-it notifications have wrong mozilla-beta revision

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Mark Banner (:standard8)]

Just submitted a build to ship-it, and we got this on thunderbird-drivers:

======
A new build has been submitted through ship-it:
mozilla commit: https://hg.mozilla.org/releases/mozilla-beta/rev/98d598127699
comm commit: https://hg.mozilla.org/releases/comm-beta/rev/98d598127699
======

The mozilla-beta rev should have been https://hg.mozilla.org/releases/mozilla-beta/rev/8bf5700cb82e

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Bug-1053195-same-m-c-c-b-changeset-in-the-email.patch

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8472999 [details] [diff] [review]
0001-Bug-1053195-same-m-c-c-b-changeset-in-the-email.patch

Review of attachment 8472999 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildfarm/release/release-runner.py
@@ +220,5 @@
> +        if name == "comm":
> +            # Thunderbird
> +            revision=r["commRevision"]
> +        else:
> +            revision=r["mozillaRevision"]

A nit. Can you add spaces around "=" when you land?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Here it is:
https://hg.mozilla.org/build/tools/rev/f726076b2e3d
Thanks

Comment 4

[Mark Banner (:standard8)]

Thanks Sylvestre, these are great improvements to ship-it :-)

Comment 5

[Rail Aliiev [:rail]]

In production