Settings button should look like a settings button

VERIFIED FIXED in Firefox 35

Status

()

Firefox for Android
Search Activity
P1
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: lucasr, Assigned: eedens)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 34
All
Android
Points:
---

Firefox Tracking Flags

(firefox35 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Or maybe just use a settings icon instead? The three-dot icon really means 'menu' on Android.
Do we have any new menu items we could add? 
"Settings", "Help", ?

Comment 2

3 years ago
I agree we should do something here. Changing the icon to a gear seems like the simplest solution to me.

Adding a "Help" option somewhere, even just in the settings for right now seems like a good idea, though. Or maybe "Feedback". But this can go in a different bug :)
Priority: -- → P1
Created attachment 8472724 [details]
icon_cog.zip

I like the idea of adding section to offer some quick tips/help to the user and maybe even tell them a little bit about what this thing is/does.

Also, here is the gear icon I made for this a while back... not sure why Ian and I decided to go for the 3 dot instead.. maybe I'll recall later. :P But I think the gear makes a lot of sense still.

Updated

3 years ago
Summary: Menu button should behave as a menu → Settings button should look like a settings button

Updated

3 years ago
Assignee: nobody → eric.edens
(Assignee)

Comment 4

3 years ago
Hey Anthony,

Is the settings icon what you were expecting?

APK for bug 1046972, bug 1053208: http://goo.gl/XeFQfY

I checked on sizing, and the gear that is bundled for the action bar [1] is 22px square, while this gear is 18px square (mdpi).  

https://developer.android.com/design/downloads/index.html
Flags: needinfo?(alam)
Looks good! :)
Flags: needinfo?(alam)
(Assignee)

Comment 6

3 years ago
Created attachment 8475182 [details] [diff] [review]
bug-1053208.patch

Swap three-dot icon for Anthony's gear icon.
Attachment #8475182 - Flags: review?(margaret.leibovic)

Updated

3 years ago
Attachment #8475182 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 7

3 years ago
https://github.com/mozilla/fennec-search/commit/80bd574794fa418b888356785c19b0ac0fc8ce86

Comment 8

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/f24fea3d1ab1

Comment 9

3 years ago
https://hg.mozilla.org/mozilla-central/rev/f24fea3d1ab1
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34

Comment 10

3 years ago
Verified as fixed in build 35.0a1 (2014-09-08);
Devices: 
Google Nexus 7 (Android 4.4.4);
Samsung Galaxy R (Android 2.3.4).
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
You need to log in before you can comment on or make changes to this bug.