1053208 - Settings button should look like a settings button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect, P1)

Description

[Lucas Rocha (:lucasr)]

Or maybe just use a settings icon instead? The three-dot icon really means 'menu' on Android.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we have any new menu items we could add? 
"Settings", "Help", ?

Comment 2

[:Margaret Leibovic]

I agree we should do something here. Changing the icon to a gear seems like the simplest solution to me.

Adding a "Help" option somewhere, even just in the settings for right now seems like a good idea, though. Or maybe "Feedback". But this can go in a different bug :)

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_cog.zip

I like the idea of adding section to offer some quick tips/help to the user and maybe even tell them a little bit about what this thing is/does.

Also, here is the gear icon I made for this a while back... not sure why Ian and I decided to go for the 3 dot instead.. maybe I'll recall later. :P But I think the gear makes a lot of sense still.

Comment 4

[Eric Edens [:eedens]]

Hey Anthony,

Is the settings icon what you were expecting?

APK for bug 1046972, bug 1053208: http://goo.gl/XeFQfY

I checked on sizing, and the gear that is bundled for the action bar [1] is 22px square, while this gear is 18px square (mdpi).  

https://developer.android.com/design/downloads/index.html

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Looks good! :)

Comment 6

[Eric Edens [:eedens]]

Attachment: bug-1053208.patch

Swap three-dot icon for Anthony's gear icon.

Comment 7

[Eric Edens [:eedens]]

https://github.com/mozilla/fennec-search/commit/80bd574794fa418b888356785c19b0ac0fc8ce86

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/f24fea3d1ab1

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f24fea3d1ab1

Comment 10

[Flaviu Cos]

Verified as fixed in build 35.0a1 (2014-09-08);
Devices: 
Google Nexus 7 (Android 4.4.4);
Samsung Galaxy R (Android 2.3.4).