1053230 - [tarako] Developers can remove their app from the Tarako Marketplace

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Mark Striemer [:mstriemer]]

Once a developer has their app listed on the Tarako Marketplace they may want to remove their app from it.

Provide developers an option to remove their app from the Tarako Marketplace when their app is currently listed on the Tarako Marketplace. Removing the app should not clear their previous review status.

Comment 1

[Mark Striemer [:mstriemer]]

Do we need to know why the app was removed? If we removed it because we got reports or the developer removed it?

Comment 2

[Andrew Williamson [:eviljeff]]

I don't think we need to know. If we remove the flag then we'll send them a message via the reviewer tools.

Comment 3

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/pull/2504

Comment 4

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/zamboni/commit/2ee014bcd7ad3d9b964328228360f140741c4625

Comment 5

[Mark Striemer [:mstriemer]]

STR

1. Request a low-memory review on your app's status page.
2. Pass the app on the Tarako review queue (/reviewers/apps/queue/additional/tarako)
3. Go back to your app's status page.
4. The Low-Memory Devices section should say "Your app is shown on low-memory devices."
5. Click the "Do not show my app on low-memory devices" button.
6. Confirm by clicking the red button on the overlay.
7. The page should refresh.
8. Confirm that the Low-Memory Devices section says "Your app is not shown on low-memory devices."

Comment 6

[krupa raj[:krupa]]

STR:
1. Approve an app for tarako
2. Go the /status page for that app, and remove the app from showing up on low memory devices

expected behavior:
We allow the developer to list the app for tarako devices without a new review for the same app

actual behavior:
The develoepr needs to get another review for a previously approved app.

Comment 7

[Mark Striemer [:mstriemer]]

We don't know whether the developer removed the tarako tag or if a reviewer did. This would mean a developer could add their app to tarako without a review if a reviewer removed the tag. There are ways around this but it's going to be some more work.

If we want to go ahead with this I think we will need to remove the ability for reviewers to take off the tarako tag and instead add a "remove from tarako" button that will add a failing review, preventing the dev from adding the tag back on manually.

Comment 8

[David Durst [:ddurst]]

Regardless of which party (the developer or the reviewer) removed the app, we should have another review; because the assumption is that something changed and we don't want to bypass the reviewer stage as the quality gate.

Comment 9

[Victor Carciu]

Verified as fixed. After reading latest comments, I will assume that it is ok if another tarako review is listed in Tarako Review Queue when developer ask again for low-memory devices support for same app.