[AccessFu] content integration test does not fully run

RESOLVED FIXED in mozilla34

Status

()

Core
Disability Access APIs
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla34
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
A missing comma makes us ignore half the test cases.. some of those cases are broken and need to be fixed.
(Assignee)

Comment 1

3 years ago
Created attachment 8472379 [details] [diff] [review]
Fix content integration tests.
Attachment #8472379 - Flags: review?(yzenevich)
Comment on attachment 8472379 [details] [diff] [review]
Fix content integration tests.

Review of attachment 8472379 [details] [diff] [review]:
-----------------------------------------------------------------

looks good with some nits.

::: accessible/tests/mochitest/jsat/test_content_integration.html
@@ +150,5 @@
>            // Open dialog in outer doc, while cursor is also in outer doc
>            [ContentMessages.simpleMoveNext, {
>              speak: ['Phone status bar', 'Traversal Rule test document']
>            }],
> +          [function() { doc.defaultView.showAlert() }, {

Missing ;
Is there a reason this is wrapped in a function?

@@ +152,5 @@
>              speak: ['Phone status bar', 'Traversal Rule test document']
>            }],
> +          [function() { doc.defaultView.showAlert() }, {
> +            speak: ['This is an alert!',
> +                    {'string': 'headingLevel', 'args':[1]},

Nit: spaces in the next 2 lines.

@@ +158,4 @@
>            }],
>  
> +          [doc.defaultView.hideAlert, {
> +            speak: ["wow",{"string":"headingLevel","args":[1]},"such app"],

Nit: spaces

@@ +171,5 @@
>              speak: ['wow', {'string': 'headingLevel', 'args': [1]}, 'such app']
>            }],
>            [doc.defaultView.showAlert, {
> +            speak: ['This is an alert!',
> +                    {'string': 'headingLevel', 'args':[1]},

Nit: spaces in the next 2 lines.

@@ +189,5 @@
>              speak: ['Phone status bar', 'Traversal Rule test document']
>            }],
>            [doc.defaultView.showAlert, {
> +            speak: ['This is an alert!',
> +                    {'string': 'headingLevel', 'args':[1]},

Nit: spaces in the next 2 lines.
Attachment #8472379 - Flags: review?(yzenevich) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4c055c3cf1f
Assignee: nobody → eitan
https://hg.mozilla.org/mozilla-central/rev/b4c055c3cf1f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.