Rocketbar should be expanded on the new tab page

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: daleharvey)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
Duplicate of this bug: 1053471
(Reporter)

Comment 2

3 years ago
Created attachment 8472692 [details]
WIP - Github pull request

Here is a naive patch which expands the rocketbar, but it's not ideal as it has the other chrome controls. 

I'm just experimenting right now - anyone can steal this.
(Assignee)

Comment 3

3 years ago
Ill take this and work on removing the rest of the chrome
Assignee: nobody → dale
(Assignee)

Comment 4

3 years ago
Created attachment 8472770 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22859

I dont love this implementation, but it works, if theres a cleaner way to do this then would be nice to hear but I couldnt think of one.
Attachment #8472770 - Flags: review?(alive)
Attachment #8472770 - Flags: feedback?(kgrandon)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8472770 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22859

My preference would be to see if we can stick something in the "chrome" manifest property, maybe "chrome": { layout: "minimal" }, but I'm not sure what kind of standardization/API implications this might have. Works for me for now.
Attachment #8472770 - Flags: feedback?(kgrandon) → feedback+
Blocks: 941182
Note that we're probably going to want this same UI on the homescreen as well (See bug 1053747), so this will probably eventually apply to both search and homescreen roles.
(Reporter)

Comment 7

3 years ago
(In reply to Ben Francis [:benfrancis] from comment #6)
> Note that we're probably going to want this same UI on the homescreen as
> well (See bug 1053747), so this will probably eventually apply to both
> search and homescreen roles.

Good point. If that's the case doing this by role does seem like it might cause problems down the road. How do we feel about trying to add something to the manifest to control this? Ni? on Jonas/Vivien to start a discussion in case they are interested in this.
Flags: needinfo?(jonas)
Flags: needinfo?(bfrancis)
Flags: needinfo?(21)
I actually think doing this based on role is a fairly clean solution which doesn't require adding any more properties to the app manifest.

We need an extra state of the Rocketbar which is used for apps with "homescreen" and "search" roles, whereby it is expanded by default, doesn't display navigation chrome but has an empty text input with a placeholder reading "Search or enter address".

I would suggest not adding the "chrome" property to the search app manifest (it doesn't need back/forward/stop/refresh/overflow), but simply adding a class to the app window (like "start-page" or similar) for apps with a homescreen or search role to indicate that app chrome should be displayed in this special state.
Flags: needinfo?(bfrancis)
(Reporter)

Comment 9

3 years ago
Ok.. I suppose I was just concerned that we may want to have third party homescreens which could opt out of showing rocketbar. Let's cross that bridge when we get to it though.
Flags: needinfo?(jonas)
Flags: needinfo?(21)
Comment on attachment 8472770 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22859

Looks fine
Attachment #8472770 - Flags: review?(alive) → review+
(Assignee)

Comment 11

3 years ago
Fixed nits

https://github.com/mozilla-b2g/gaia/commit/f33f82d7d97c36a1ff392ac41132319c2a0bf666

I think its worth taking a look if we want to do this on role / new property when we change behavior for the homescreen, but I do think for now its better than adding a new property
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
How come the Rocketbar doesn't collapse on scroll in this app?
Flags: needinfo?(dale)
(Assignee)

Comment 13

3 years ago
Similiarly to the browser, I didnt expect we would want the address bar to scroll off in this page so its specifically disabled, Francis?
Flags: needinfo?(fdjabri)
(Assignee)

Updated

3 years ago
Flags: needinfo?(dale)
According to the Browser Chrome spec (v0.5, page 15), the Rocket bar should collapse into the status bar, as with other browser windows. I'd prefer a consistent approach here as it would help people learn the general behaviour.
Flags: needinfo?(fdjabri)
You need to log in before you can comment on or make changes to this bug.