1053258 - Change Search icon to Browser icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

From bug 1041620 comment 22

The Browser icon is called "Search" and has a search icon. The spec requires it to be called "Browser" and have a browser icon but for "Search or enter address" placeholder text to appear in the Rocketbar on the new tab page.

This might need to wait until the old browser app goes away.

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Let's land this after we have hidden the old browser app.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8473694 [details] [review]
Github pull request

Let's get this reviewed so we are ready to land when the browser app is gone. Marking Ben and Francisco as possible reviewiers - whoever is free please clear the other. Thanks!

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8473694 [details] [review]
Github pull request

r+

Note that the spec says that the browser icon should be called "Browser" but that the Rocketbar should say "Search or enter address" when the browser app is launched. I think a good approach to this would be a new expanded Rocketbar state which displays this placeholder instead of a title for the "search" and "homescreen" roles.

I think we could probably land this now if we just called it Browser2.

Comment 5

[Kevin Grandon :kgrandon]

Ok, thanks Ben. Yes, we also need to update the title content as well.

If there's value in landing this now, I'll go ahead and update the name to 'Browser2' so we can do so. Thanks for the quick turnaround on the review.

Comment 6

[Kevin Grandon :kgrandon]

Update commit to have r=benfrancis, and landed with the 'Browser2'.

https://github.com/mozilla-b2g/gaia/commit/b36d8b827a690ca0d16de85caa416747e6d33cca

Comment 7

[Francesco Lodolo [:flod]]

Is the name "Browser2" going to be displayed anywhere? This strings are exposed to the localization process, and that 2 looks quite weird.

Comment 8

[Ben Francis [:benfrancis]]

This is just a placeholder until we delete the browser app in bug 1043959, otherwise we will have two icons on the homescreen called "Browser".

Comment 9

[Francesco Lodolo [:flod]]

It would have been probably clearer to land the change directly as "Browser", after the other icon is gone (we also suffer from bug 849028, so we need to send messages out about these changes, and hope in tools and localizers to catch up).

Comment 10

[Kevin Grandon :kgrandon]

(In reply to Francesco Lodolo [:flod] from comment #9)
> It would have been probably clearer to land the change directly as
> "Browser", after the other icon is gone (we also suffer from bug 849028, so
> we need to send messages out about these changes, and hope in tools and
> localizers to catch up).

Sorry about that, definitely don't want to create extra churn for localizers. Is there any way to "skip" this "Browser2" string? I'm also open to backing this out until the browser app is removed if that is preferable.

Comment 11

[Ben Francis [:benfrancis]]

Can we just warn localizers about this change? They're probably going to be more interested that we're deleting an entire app and all of its strings than one string being one character different for a week or two in the system app.

What's the best way to communicate this?

Comment 12

[Axel Hecht [:Pike]]

The communication channels to the l10n community are fragile, they'll just work on whatever we give them.

Note, we don't notify anyone about the renames of apps by default, so I guess we'll just hold off announcing (yet another) rename of the search app.