Closed Bug 1053269 Opened 5 years ago Closed 5 years ago

No null-check for ownerDoc OpenDatabaseHelper.cpp line 1710

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Attached patch ownerDoc.patchSplinter Review
https://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/OpenDatabaseHelper.cpp#1710

I don't know if it's needed. I didn't see any crash, but I was checking this code and I saw that ownerDoc is check here:

 if (ownerDoc && (bfCacheEntry = ownerDoc->GetBFCacheEntry())) {

but not here:

 ownerDoc->DisallowBFCaching();
Attachment #8472392 - Flags: review?(ehsan)
Attachment #8472392 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/d6daf663bfb2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.