Closed
Bug 1053302
Opened 10 years ago
Closed 10 years ago
Missing space between “terms” and “and” on signup modal
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Webmaker Graveyard
webmaker.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: akirose, Assigned: akshaytiwari.003, Mentored)
Details
(Whiteboard: [goodfirstbug])
Attachments
(3 files, 1 obsolete file)
This happened on profile, so it may or may not be scoped to signups on profile, but is definitely related to webmaker-auth-client.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → akshaytiwari.003
Assignee | ||
Comment 1•10 years ago
|
||
The bug has already been resolved.
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8474091 -
Flags: review?(aki)
Reporter | ||
Comment 3•10 years ago
|
||
Nope, it's still on prod. You can see it here. This is the offending LoC: https://github.com/mozilla/webmaker-profile-2/blob/master/app/_partials/create-user-form.html#L27-27
Did you want to take this bug?
Attachment #8474091 -
Attachment is obsolete: true
Attachment #8474091 -
Flags: review?(aki)
Flags: needinfo?(akshaytiwari.003)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8474207 -
Flags: review?(aki)
Flags: needinfo?(akshaytiwari.003)
Assignee | ||
Comment 5•10 years ago
|
||
Sorry! Wrong place. Cancel the review. I've put   at a wrong place.
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Comment 7•10 years ago
|
||
it has been corrected.
Reporter | ||
Updated•10 years ago
|
Attachment #8474207 -
Flags: review?(aki) → review-
Comment 8•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-profile-2
https://github.com/mozilla/webmaker-profile-2/commit/ccc6751881b9eb6813ff3528afc51422c978b917
Merge pull request #83 from jee1mr/patch-1
Fixes Bug 1053302 - Missing space between “terms” and “and” on signup modal
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•