[Search] app/site from RB search the page should slide in from the right

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: epang, Assigned: etienne)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
kgrandon
: review+
epang
: ui-review+
Details | Review
Reporter

Description

5 years ago
When a user does a search in rocket bar presses 'go' or taps a icon a new sheet should slide in from the right where the page loads.

See the flow here:
> https://mozilla.box.com/s/g2of03hha34htbc4keep

If the user is already in the browser it should load as is.
Reporter

Updated

5 years ago
Summary: [Search] New site in browser from RB search should come in as a new sheet → [Search] app/site from RB search the page should slide in from the right
Assignee

Comment 1

5 years ago
Posted file Gaia PR
Hey Eric, the way the focused rocketbar is implemented it's really an overlay on top of everything else so I don't think we'll be able to have it slide to the left when we open something in the 2.1 timeframe.

That said, currently we have absolutely no transition when launching something from the rocketbar which is really bad too.

This patch is a compromise: when launching something from the rocketbar/search we hide the overlay first then slide the app/website from the right.
Can you give it a spin? I think it's still a big win UX wise.
Assignee: nobody → etienne
Attachment #8476007 - Flags: ui-review?(epang)
Reporter

Comment 2

5 years ago
Comment on attachment 8476007 [details] [review]
Gaia PR

R+ This is great, thanks for working on this Etienne!
Attachment #8476007 - Flags: ui-review?(epang) → ui-review+
Assignee

Comment 3

5 years ago
Comment on attachment 8476007 [details] [review]
Gaia PR

Added unit-tests, ready for review.
Attachment #8476007 - Attachment description: Gaia PR - WIP → Gaia PR
Attachment #8476007 - Flags: review?(kgrandon)
Comment on attachment 8476007 [details] [review]
Gaia PR

I do think that it might be a little strange launching things after focusing on the homescreen rocketbar show it, but I guess that's what we have today. This is a much smoother transition, nice work!
Attachment #8476007 - Flags: review?(kgrandon) → review+
Assignee

Comment 5

5 years ago
https://github.com/mozilla-b2g/gaia/commit/43cd00547711c14ac1ec8789796a881b2c5b32cd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 1111524
You need to log in before you can comment on or make changes to this bug.