When a user does a search in rocket bar presses 'go' or taps a icon a new sheet should slide in from the right where the page loads. See the flow here: > https://mozilla.box.com/s/g2of03hha34htbc4keep If the user is already in the browser it should load as is.
Summary: [Search] New site in browser from RB search should come in as a new sheet → [Search] app/site from RB search the page should slide in from the right
Hey Eric, the way the focused rocketbar is implemented it's really an overlay on top of everything else so I don't think we'll be able to have it slide to the left when we open something in the 2.1 timeframe. That said, currently we have absolutely no transition when launching something from the rocketbar which is really bad too. This patch is a compromise: when launching something from the rocketbar/search we hide the overlay first then slide the app/website from the right. Can you give it a spin? I think it's still a big win UX wise.
Assignee: nobody → etienne
Attachment #8476007 - Flags: ui-review?(epang)
Comment on attachment 8476007 [details] [review] Gaia PR R+ This is great, thanks for working on this Etienne!
Attachment #8476007 - Flags: ui-review?(epang) → ui-review+
Comment on attachment 8476007 [details] [review] Gaia PR Added unit-tests, ready for review.
Comment on attachment 8476007 [details] [review] Gaia PR I do think that it might be a little strange launching things after focusing on the homescreen rocketbar show it, but I guess that's what we have today. This is a much smoother transition, nice work!
Attachment #8476007 - Flags: review?(kgrandon) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.