pymake hacks in release repacks drop all but one signing server from list



5 years ago
5 years ago


(Reporter: bhearsum, Assigned: bhearsum)


Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)

c:\builds\moz2_slave\tb-rel-c-beta-w32_rpk_1-000000\comm-beta\obj-l10n\mail\locales\Makefile:115:0: command 'c:/mozilla-build/python27/python.exe c:/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/comm-beta/mozilla/build/pymake/pymake/../ repackage-win32-installer AB_CD=br WIN32_INSTALLER_IN=c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\thunderbird.exe' failed, return code 2
Usage: [options] file [file ...]

If no include patterns are specified, all files will be considered. -i/-x only
have effect when signing entire directories. error: no hosts capable of signing formats: signcode

  MOZ_SIGN_CMD=python /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/scripts/release/signing/ --cachedir /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/signing_cache -t /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/token -n /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/nonce -c /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/scripts/release/signing/host.cert -H -H -H -H -H -H -H -H -H
The actual command that tried to execute was:
c:\builds\moz2_slave\tb-rel-c-beta-w32_rpk_1-000000\comm-beta\mozilla\toolkit\mozapps\installer\windows\nsis\$ python c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\scripts\\\\release\\\\signing\\\\ --cachedir c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\signing_cache -t c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\token -n c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\nonce -c c:\\\\builds\\\\moz2_slave\\\\tb-rel-c-beta-w32_rpk_1-000000\\\\scripts\\\\release\\\\signing\\\\host.cert -H -f signcode "l10ngen/setup.exe"

Which makes it look like something somewhere is dropping some of the potential hosts....
The problem is this long lived hack which strips out all but one of the signing servers:

Fix is incoming.
Assignee: nobody → bhearsum
Created attachment 8472514 [details] [diff] [review]
use multiple signing servers for release repacks again

I tested all the splitting parts by hand:
>>> foo = "python /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/scripts/release/signing/ --cachedir /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/signing_cache -t /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/token -n /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/nonce -c /c/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/scripts/release/signing/host.cert -H -H -H -H -H -H -H -H -H"
>>> a = foo.split("-H", 1)[1].split("-H")
>>> a[0]
' '

I think the rest is trivial enough...
Attachment #8472514 - Flags: review?(rail)
Created attachment 8472519 [details] [diff] [review]
use correct way to append a string
Attachment #8472519 - Flags: review?(rail)

Comment 5

5 years ago
Comment on attachment 8472519 [details] [diff] [review]
use correct way to append a string

Review of attachment 8472519 [details] [diff] [review]:

::: scripts/l10n/
@@ +88,5 @@
>              " -c " + \
> +            path.join(os.getcwd(), "scripts", "release", "signing", "host.cert").replace('\\', '\\\\\\\\')
> +        signingServers = os.environ["MOZ_SIGN_CMD"].split("-H", 1)[1].split("-H")
> +        for s in signingServers:
> +            env["MOZ_SIGN_CMD"] += " -H %s" % s.strip

Just add () at the end.
Attachment #8472519 - Flags: review?(rail) → review+


5 years ago
Attachment #8472514 - Attachment is obsolete: true
Attachment #8472514 - Flags: review?(rail)
Summary: signtool changes for mac v2 signing broke win32 release repacks → pymake hacks in release repacks drop all but one signing server from list
Comment on attachment 8472519 [details] [diff] [review]
use correct way to append a string

Landed, with the needed ():
Attachment #8472519 - Flags: checked-in+
This worked. bug 1053378 is going to look at removing these crappy hacks altogether.
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.