Closed
Bug 1053418
Opened 10 years ago
Closed 10 years ago
typos in shared/style/icons/icons.html and shared/style/icons/selection.json
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crosbow, Assigned: pivanov)
Details
Attachments
(1 file, 1 obsolete file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release) Build ID: 20140813004001 Steps to reproduce: I checked the BB icons demo and saw some typos Actual results: i changed the files on github Expected results: i should have made an bug report and follow the submitting guidelines
https://github.com/mozilla-b2g/gaia/pull/22895
Attachment #8473133 -
Flags: review?(poirot.alex)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8473133 [details] [review] https://github.com/mozilla-b2g/gaia/pull/22895 I'm not reviewer for this code.
Attachment #8473133 -
Flags: review?(poirot.alex) → review?(pivanov)
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8473133 [details] [review] https://github.com/mozilla-b2g/gaia/pull/22895 LGTM :) but please rebase first before merge and ping me back if you need me to merge this one :)
can i rebase with a shallow local repo? im on slow unstable connection and cant clone the whole repo. maybe someone else can rebase this and submit the PR?
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8473648 -
Flags: review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8473133 -
Attachment is obsolete: true
Attachment #8473133 -
Flags: review?(pivanov)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Thanks :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/f1675b1582b287682cf57acbb36be0a59d5b44c0
Assignee: nobody → pivanov
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•