If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update download failure message is not specific enough

NEW
Unassigned

Status

()

Firefox for Android
General
3 years ago
a year ago

People

(Reporter: glandium, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
A user had a "Download failed. Touch to retry" message, and his log were saying:

I/UpdateService( 9792): opening connection with url:
https://aus4.mozilla.org/update/4/Fennec/33.0a1/20140717030339/Android_arm-eab
i-gcc3/en-US/nightly/2.2/default/default/33.0a1/update.xml
I/UpdateService( 9792): opening connection with url:
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2014/08/2014-08-12-03-02
-02-mozilla-central-android/fennec-34.0a1.multi.android-arm.apk
E/UpdateService( 9792): at
org.mozilla.gecko.updater.UpdateService.downloadUpdatePackage(UpdateService.ja
va:457)
E/UpdateService( 9792): at
org.mozilla.gecko.updater.UpdateService.startUpdate(UpdateService.java:249)
E/UpdateService( 9792): at
org.mozilla.gecko.updater.UpdateService.onHandleIntent(UpdateService.java:125)

The corresponding code is:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/updater/UpdateService.java#457

which suggests what failed is not the network part of the download, but the writing part of the download (possibly not enough disk space, I don't have an answer yet as to what the root cause is for him)

It would be better to have a different error when the failure is to write the download as opposed to getting data from the network, making things clearer to the user (because in the former case, retrying is not going to achieve anything unless some cleanup is performed first, which the user doesn't know he needs to do)
You need to log in before you can comment on or make changes to this bug.