Closed
Bug 1053617
Opened 10 years ago
Closed 10 years ago
Reduce scope of stdio/FILE-related declarations to pkixtestutil.cpp
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
3.21 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
See patch. This stuff is local to pkixtestutil.cpp and so it shouldn't be in pkixtestutil.h
Attachment #8472774 -
Flags: review?(dkeeler)
Comment 1•10 years ago
|
||
Comment on attachment 8472774 [details] [diff] [review]
reduce-FILE-scope.patch
Review of attachment 8472774 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good.
::: security/pkix/test/lib/pkixtestutil.h
@@ -45,1 @@
> : Input(reinterpret_cast<const uint8_t(&)[N-1]>(valueString))
I think this file still has '#include <stdio.h>' which doesn't seem necessary now.
Attachment #8472774 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to David Keeler (:keeler) [use needinfo?] from comment #1)
> ::: security/pkix/test/lib/pkixtestutil.h
>
> I think this file still has '#include <stdio.h>' which doesn't seem
> necessary now.
I removed that include. Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/29003f6d5f22
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•