Closed Bug 1053620 Opened 6 years ago Closed 6 years ago

Replace uses of PR_Abort with uses of abort in the mozilla::pkix test suite

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file)

no-more-PR_Abort.patch
5.54 KB, patch
keeler
: review+
Details | Diff | Splinter Review 
No description provided.
Attachment #8472777 - Flags: review?(dkeeler)
Comment on attachment 8472777 [details] [diff] [review]
no-more-PR_Abort.patch

Review of attachment 8472777 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. For the gtests, is there a gtest-specific abort we want to call?
Attachment #8472777 - Flags: review?(dkeeler) → review+
(In reply to David Keeler (:keeler) [use needinfo?] from comment #1)
> Ok. For the gtests, is there a gtest-specific abort we want to call?

I looked at the GTest docs, and there doesn't seem to be anything that GTest prefers over standard abort().

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a4a35ef4d0f
https://hg.mozilla.org/mozilla-central/rev/0a4a35ef4d0f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.