Closed Bug 1053624 Opened 10 years ago Closed 10 years ago

Extract and organize Input Management showAll()

Categories

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S4 (12sep)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

Attachments

(1 file)

Let's extract the anonymous callbacks from ImeMenu in |KeyboardManager.showAll()| to smaller functions.
Working on this. This will not get into 2.1 FL to avoid regressions.
Assignee: nobody → jlu
Target Milestone: --- → 2.1 S4 (12sep)
Attached file Patch (PR @ GitHub)
Let's get it tested.
Comment on attachment 8473546 [details] [review]
Patch (PR @ GitHub)

Hi Tim,

Could you review this refactoring patch? |KeyboardManager.showAll()| is now more tangible. What's more important is that with this refactoring it's now easier to write tests for |showAll()| -- and that's what I have done in this patch too (as well as test for |switchToNext()|).

I tend to keep the extracted functions (those are concerned with switching keyboards) in KeyboardManager in the near future as I'm not sure if creating a new module would make merging with Alive's future system app refactoring work harder.
Attachment #8473546 - Flags: review?(timdream)
Comment on attachment 8473546 [details] [review]
Patch (PR @ GitHub)

Look good!
Attachment #8473546 - Flags: review?(timdream) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/e1f6d88db39084c98a7d4e361ba30447a8b4264e

Merged despite one Gij failure that's present in others' PRs.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: