Closed Bug 1053669 Opened 10 years ago Closed 10 years ago

[Settings] Missing strings in properties file

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(b2g-v2.1 verified)

VERIFIED FIXED
2.1 S2 (15aug)
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(2 files)

https://github.com/mozilla-b2g/gaia/commit/8a5c9ada8372f511e365d0ae9151b55079aebc3a

String has a data-l10n-id but it's not extracted to settings.en-US.properties
Summary: Missing string "shake-to-log" in properties file → [Settings] Missing string "shake-to-log" in properties file
Attached file bug1019709.patch
Assignee: nobody → francesco.lodolo
Attachment #8472855 - Flags: review?(timdream)
Another string missing from bug 1023735, adding to this one and updating PR.
Blocks: 1023735
Summary: [Settings] Missing string "shake-to-log" in properties file → [Settings] Missing string "shake-to-log" and 'time-format-time' in properties file
There's a third string, at this point double checking both commits :-\
Summary: [Settings] Missing string "shake-to-log" and 'time-format-time' in properties file → [Settings] Missing strings in properties file
Attachment #8472855 - Flags: review?(timdream)
Oops thanks for finding the missing strings.
Comment on attachment 8472855 [details] [review]
bug1019709.patch

Back to review, I double-checked and I think I got them all now.
Attachment #8472855 - Flags: review?(timdream)
Attachment #8472855 - Flags: review?(timdream) → review+
I don't think we need to wait for tests, given that this patch only adds strings. Setting keyword for check-in.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/43bfc3a7a7e351345a9d441e69c2fdc1db7c8446
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S2 (15aug)
Verified on
Gaia      0cd506156fb6f2431d01cf37e6e5db37cea68c07
Gecko     https://hg.mozilla.org/mozilla-central/rev/9eb591a1a203
BuildID   20140814160206
Version   34.0a1
Status: RESOLVED → VERIFIED
This issue has been verified successfully on Flame2.1
Verify video:"verify_1053669.mp4".
**Fefering Bug 1093602, I can see logshake feature was removed from V2.1.

Flame2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: