If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Flatfish][Rocket bar] In search page, the ratio of app icon's size to frame's size is not correct.

VERIFIED FIXED

Status

Firefox OS
Gaia::Search
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: eva.chen.fx, Assigned: chens)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Flatfish][TCP])

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
Created attachment 8472930 [details]
screenshot_icon.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

1. Update a Flatfish to BuildID: 20140814012429
2. Open Settings app.
3. Tap the Rocket bar.
   (Rocket bar: The left side of the Rocket bar displays the title of the current app.)
4. Type any text(ex: con) into the 'Search or enter address' fields.

-----------------------------------------------
Environment Info:
BuildID: 20140814012429
Gaia: a2219a55145e730e56e09527b40152d68a43b0d9
Gecko:76da7b9ce541beb416180f260bf6d82685dc9c49
B2G: 2.1.0.0-prerelease
Platform version : 34.0a1
Repro frequency: 100%
See attached: screenshot_icon.jpg


Actual results:

<ISSUE> In search page, the ratio of app icon's size to frame's size is not correct. The icon's size is abnormally big.
(Reporter)

Updated

3 years ago
Blocks: 903304
Whiteboard: [Flatfish][TCP]
(Assignee)

Updated

3 years ago
Assignee: nobody → shchen
(Assignee)

Comment 1

3 years ago
Created attachment 8473590 [details] [review]
WIP

WIP: https://github.com/mozilla-b2g/gaia/pull/22920

I found gaia_grid component could have some issue on tablet and I create a WIP patch for it, could you take a look and give me some feedback? thanks.
Attachment #8473590 - Flags: feedback?(kgrandon)
Attachment #8473590 - Flags: feedback?(crdlc)
I think this was also potentially preventing us from using the vertical homescreen. Perhaps we can enable that for tablet in 2.1?
Sherman - could you post an "after" picture of the new grid? Thanks!
Flags: needinfo?(shchen)
Comment on attachment 8473590 [details] [review]
WIP

I think something like this is probably fine. We should probably have a test, and this could probably be tested with unit tests, though I'm not so sure how effective those would be. Thanks.
Attachment #8473590 - Flags: review+
Attachment #8473590 - Flags: feedback?(kgrandon)
Attachment #8473590 - Flags: feedback?(crdlc)
(Assignee)

Comment 5

3 years ago
Created attachment 8474308 [details]
grid_item_before.png
(Assignee)

Comment 6

3 years ago
Created attachment 8474309 [details]
grid_item_after.png
Flags: needinfo?(shchen)
(Assignee)

Comment 7

3 years ago
(In reply to Kevin Grandon :kgrandon from comment #2)
> I think this was also potentially preventing us from using the vertical
> homescreen. Perhaps we can enable that for tablet in 2.1?

Yeah, I also try to enable vertical homescreen on tablet and everything seems fine. 
Once we have updates from UX then we can enable vertical home for tablet.
(Assignee)

Comment 8

3 years ago
Merged to master: 
https://github.com/mozilla-b2g/gaia/commit/f9fe210844d10be23bdcf2e0c31a8c6f53307158
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

3 years ago
App icon size displays properly from rocket bar search result.
Verified okay and close the bug.
Device: Flatfish 2.1 Master
Gaia      4ccb207518f62baa5160a735a6189d3ba9d34e1d
Gecko     64c4bef1c1234d2fdd60974ed30d1034ec570c34
BuildID   20140821013807
Version   34.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.