Closed Bug 1053730 Opened 10 years ago Closed 10 years ago

Update simulator builds so that web components are not enabled by default

Categories

(Firefox OS Graveyard :: Simulator, defect)

Product:
Firefox OS Graveyard
Component:
Simulator
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sole, Assigned: ochameau)

References

Details

Attachments

(1 file)

simulators not updated??
736.67 KB, image/png
Details 
As a follow up of #1052150 which blocks #1052140 - please update the simulators so we can develop web components based code in Gaia 2.x, otherwise we just end up in this cul-de-sac: https://github.com/mozbrick/brick/issues/258
Blocks: 1052150
/me downloading 2.1 nightly builds to test them before pushing them.
2.1/Nightly builds are broken :'(

The following ressouce doesn't exists on Fx31...
resource://gre/modules/sdk/system/Startup.js
http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/app-extension/bootstrap.js#29

Due to bug 1042239.
I know the SDK doesn't necessarely support older version of Firefox (ie. something older than the version of m-c your are building from). So I don't know exactly how to proceed.

Erik, any advice?
Flags: needinfo?(evold)
/me downloading 2.0 nightly builds. They shouldn't contain bug 1042239.
(In reply to Alexandre Poirot [:ochameau] from comment #2)
> 2.1/Nightly builds are broken :'(
> 
> The following ressouce doesn't exists on Fx31...
> resource://gre/modules/sdk/system/Startup.js
> http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/app-extension/
> bootstrap.js#29
> 
> Due to bug 1042239.
> I know the SDK doesn't necessarely support older version of Firefox (ie.
> something older than the version of m-c your are building from). So I don't
> know exactly how to proceed.
> 
> Erik, any advice?

I'm not sure how often you build updates, and if you need to build of the sdk master branch or not.

Using the 1.17.1 build that is about to be released could work here.
Flags: needinfo?(evold)
(In reply to Alexandre Poirot [:ochameau] from comment #2)
> 2.1/Nightly builds are broken :'(
> 
> The following ressouce doesn't exists on Fx31...
> resource://gre/modules/sdk/system/Startup.js
> http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/app-extension/
> bootstrap.js#29
> 
> Due to bug 1042239.
> I know the SDK doesn't necessarely support older version of Firefox (ie.
> something older than the version of m-c your are building from). So I don't
> know exactly how to proceed.

There was another issue recently (bug 1037474) which also broke simulators on release channel Firefox.  We may need to reconsider how we build the addon if we are going to keep getting issues like this.  Do we need to switch to the released SDK build, instead of just using what's in m-c along side the code being built?
I released new builds for 2.0.
For 2.1, we will have to get out of another "cul-de-sac" before reviving nightlies/2.1.

I'm wondering if it wouldn't be just easier to use a bootstrapped addon :/
Most of the work would be about crafting the update manifest correctly.
Depends on: 1056136
So bug 1056136 is now landed... but we now get the following exception when trying to install the addon on windows:

Failed to install ...\fxos-simulator-2.1-win32.xpi from file:///.../fxos-simulator-2.1-win32.xpi: Win error 3 during operation open on file ...\AppData\Roaming\Mozilla\Firefox\Profiles\q26ze7sa.nightly\extensions\staged\fxos_2_1_simulator@mozilla.org\b2g\AccessibleMarshal.dll (Le chemin d’accès spécifié est introuvable.)

It means that I still can't spin 2.1 updates... or at least not on windows.
Assignee: nobody → poirot.alex
Depends on: 1061684
Ok, so bug 1061684 landed, but only on 2.2.
Still can't spawn new 2.1 builds... but I requested the uplift.
Hopefully, one day, we will have updated 2.1 builds.

In the meantime I released builds for 2.2:
  https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/2.2/
(In reply to Alexandre Poirot [:ochameau] from comment #8)
> Ok, so bug 1061684 landed, but only on 2.2.
> Still can't spawn new 2.1 builds... but I requested the uplift.
> Hopefully, one day, we will have updated 2.1 builds.
> 
> In the meantime I released builds for 2.2:
>   https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/2.2/

Cool!  Can you add this to the index.(html|json) files?

Also, probably 2.0 can be marked "stable" now I would think.
Flags: needinfo?(poirot.alex)
Your Mac 2.2 release works for me.
2.2 added to indexes.
I'll publish new 2.0 builds before promoting it as stable.
Flags: needinfo?(poirot.alex)
I just finished pushing new builds for 2.0 and 2.1!
Web components should work now.
2.0 is now described as being stable.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
How can I confirm this is the case?

I'm not able to load about:config in the browser using the simulators to confirm, and my component still looks busted when I run the app simulator installed from: ftp://ftp.eu.mozilla.org/pub/labs/fxos-simulator/index.html

I just want to confirm that I'm past this bug, and possibly hitting another.
I haven't verified myself what was wrong about webcomponents, just assumed it needs updating gecko/gaia to latest version.
I thought it was some pref being set in an old version of gecko or gaia?
Does it work on 2.2/2.1 builds?
Flags: needinfo?(sole)
I'm using a polyfil called Polymer, which works in 1.4 but is broken on 2 and higher.

I found this bug through https://bugzilla.mozilla.org/show_bug.cgi?id=1052150

What I would love is the ability to actually turn off or check dom.webcomponents.enabled to help debug. If I could turn that off, and see things work again, I could confirm that's the problem. If I turn it off and it's still busted, then I can know it's something else.

It there an easy way to change or check dom.webcomponents.enabled in FF os?
On all 2.x (2.0, 2.1 and 2.2) builds I have now, this pref is false.

You can easily check this by opening the simulators from WebIDE and then debug the "Main process" in the app list.
If you go in the webconsole you can execute:
  Services.prefs.getBoolPref("dom.webcomponents.enabled")
And if you want to play with prefs, you can do:
  Services.prefs.setBoolPref("dom.webcomponents.enabled", true)
and reboot the simulator to see the difference.
Cool, thanks! I wasn't aware of the WebIDE, very cool.

So yeah, looks like it is set to false, yet things are still busted, so it's likely something else, possibly on my end. I'll debug.
After a bit of debugging, it looks like <link ref="import" href="link/to/file.html"> is not working in 2.0 and up.
I just installed the 2.2 simulator and this works now (dom.webcomponents.enabled = false) so Polymer kicks into action.

With 2.0 it works too, but 2.1 seems still busted.
Status: RESOLVED → REOPENED
Flags: needinfo?(sole) → needinfo?(poirot.alex)
Resolution: FIXED → ---
I just found out that html imports like above is also a polymer shim, so that's likely why it's not working for me.
It think that's another issue or you are not testing with the very last 2.1 build.
I just downloaded 2.1 from WebIDE interface and verified that dom.webcomponents.enabled was set to false.
Any chance you can confirm what is exactly broken with polymer?
Is it the html imports Scott mentioned? Was that already the thing that broke because of webcomponents being enabled?
Flags: needinfo?(poirot.alex)
How do I update the simulator?
It should be somehow automagically updated every now an then by firefox (tbh I don't remember the workflow :/)
but you can force an update check in about:addons, right click on the addon and "Find updates".
It should find some and start downloading a new one.
(In reply to Soledad Penades [:sole] [:spenades] from comment #23)
> How do I update the simulator?

You can right-click, check for update, but please, don't do it. I want to make sure auto update works. Just wait 24h.
2.1 and 2.2 are up to date. I don't know about the others.
OK will check tomorrow again ^_^ NO FORCE UPDATE I PROMISE
Should I file something that the import polyfil is broken in 2.0 and up? No idea if it's FFOS end of Polymer's end. It did work fine in 1.4 though.

I already have an issue filed with them that has been completely silent: https://github.com/Polymer/polymer/issues/713 so maybe that's in the wrong spot?

I'm trying to make a reduced test case.
OK, I made a reduced test case that hits my problem in 2.0 and up, but is fine with 1.4.

http://scottdowne.github.io/ffos-link-example/

New issue though? I can file, but not where where.
(In reply to Scott [:thecount] Downe from comment #29)
> OK, I made a reduced test case that hits my problem in 2.0 and up, but is
> fine with 1.4.
> 
> http://scottdowne.github.io/ffos-link-example/
> 
> New issue though? I can file, but not where where.

Yes, I'd say file a new issue in this Simulator component.  Not sure of the root cause exactly, but it does seem to be a Firefox change, and we can move that issue if needed as we learn more.
Cool thanks! Filed it here: https://bugzilla.mozilla.org/show_bug.cgi?id=1071629

The original issue, seems to be fixed for 2.0 and up on my end, including 2.1.
Alex, is this resolved now?
Flags: needinfo?(poirot.alex)
For me, it is fixed.
I haven't heard from sole confirmation about 2.1.
Flags: needinfo?(poirot.alex) → needinfo?(sole)
Alex, remember this comment? https://bugzilla.mozilla.org/show_bug.cgi?id=1053730#c25
The 2.1 simulator is still last updated on July. I'll open a bug and cc Paul because I don't know if he wants me to keep waiting until the simulator autoupdates itself :P
Flags: needinfo?(sole)
Depends on: 1078339
As said during the meeting, it is most likely because you ended up installing 2.1 from nightly builds.
They are not autoupdated!
So please install 2.1 builds from https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/
Then, they will be autoupdated again.
(In reply to Alexandre Poirot [:ochameau] from comment #35)
> As said during the meeting, it is most likely because you ended up
> installing 2.1 from nightly builds.
> They are not autoupdated!
> So please install 2.1 builds from
> https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/
> Then, they will be autoupdated again.

Maybe we should add something to the version number or name of nightly builds, so we can determine this situation more easily.  Filed bug 1078346.
Alex, I didn't install nightly builds. I installed them all via WebIDE--not sure if I made this explicit already. I don't even know how to install nightly builds ;-)
2.1 builds are fixed now, the update issue is for bug 1078339.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: